|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
We can't kill enablePrivilege from Talos yet, but it should not be used in any other test suites. security.turn_off_all_security_so_that_viruses_can_take_over_this_computer was introduced to enable enablePrivilege in automation, but it is overloaded for various other purposes now. So we will have to add a new pref to control only enablePrivilege.
don't we have many other cases of enablePrivilege in tree outside of Talos: https://dxr.mozilla.org/mozilla-central/search?q=enablePrivilege Is there a reason why we cannot kill this from Talos?
(In reply to Joel Maher ( :jmaher) from comment #2) > don't we have many other cases of enablePrivilege in tree outside of Talos: > https://dxr.mozilla.org/mozilla-central/search?q=enablePrivilege Those tests are dead (not running in automation). I'm not bothered to remove or restore them. > Is there a reason why we cannot kill this from Talos? Bug 715588 was WONTFIXed. It will take time to write a custom extension, sign the extension, make sure it does not introduce instability, seek some alternatives if it does, etc. But I would not like to leave enablePrivilege enabled in other test suites just because I can't remove enablePrivilege from Talos at the moment.
For talos there is talos-powers which is used by all tests. The bug referenced was closed 3 years ago, a lot has changed since then. I notice this patch deletes a test case test_bug504877.html, is that case not providing any value? How did we determine it was ok to delete the test? I need to understand more before giving this an r+. In talos a lot of the instanced of enablePrivilege are related to the profiler, I suspect with talos-powers we could resolve anything we need, or maybe with the new profile built in we don't need this: https://dxr.mozilla.org/mozilla-central/search?q=path%3Atesting%2Ftalos+enablePrivilege&redirect=true
Comment on attachment 8869400 [details] Bug 1365199 - Add an enablePrivilege specific pref and use it in Talos. waiting on more data before doing formal review.