1365213 - location and search inputs are too small

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Fix location and search bar height

This also fixes a typo in the location bar background color definition on linux that smaug noticed

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Screenshot on OSX

Comment 3

[Dão Gottwald [:dao]]

I think it's probably better to use min-height here like we do on Windows 10: http://searchfox.org/mozilla-central/rev/ae24a3c83d22e0e35aecfd9049c2b463ca7e045b/browser/themes/windows/browser.css#762-766

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Screenshot on Windows

Comment 5

[Dale Harvey (:daleharvey)]

ok cool will give that a shot

Comment 6

[Darkspirit]

(In reply to Dale Harvey (:daleharvey) from comment #4)
> Created attachment 8868130 [details]
> Screenshot on Windows

https://mozilla.invisionapp.com/share/ZKBC94BPQ#/screens/231292511
My perception is that the "back" button has the same distance to the button as the locationbar.

On your screenshot, the locationbar seems to have more space below and above compared to the one from invision. (Maybe you can't make those gaps smaller because of the Australis tab style/implementation?) I am also unsure about the font size.

Comment 7

[Darkspirit]

(In reply to Darkspirit from comment #6)
correction: "same distance to the bottom" (Sorry for spam :/)

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Fix location and search bar height

Comment 9

[Dale Harvey (:daleharvey)]

I removed "font: icon", as we discussed it was (confusingly) making the url bar text smaller whereas the font size is consistent in the mockups and addressed the font-size

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8868194 [details] [diff] [review]
Fix location and search bar height

>--- a/browser/themes/shared/location-search-bar.inc.css
>+++ b/browser/themes/shared/location-search-bar.inc.css
>@@ -5,18 +5,20 @@
> #urlbar,
> .searchbar-textbox {
>   -moz-appearance: none;
>   background-clip: content-box;
>   background-color: var(--urlbar-background-color);
>   border: 1px solid var(--urlbar-border-color);
>   border-radius: var(--toolbarbutton-border-radius);
>   box-shadow: 0 1px 4px hsla(0, 0%, 0%, .05);
>+  font-size: 14px;

Please remove this as we shouldn't hard-code font-sizes to px values.

Comment 11

[Dale Harvey (:daleharvey)]

Attachment: Fix location and search bar height

Removed the pixel font size, linux has the correct size by default and the existing windows rule matches the redesign, specified a custom osx one in em's

Comment 12

[Dale Harvey (:daleharvey)]

Attachment: Screenshot on OSX

Comment 13

[Dale Harvey (:daleharvey)]

Attachment: Screenshot on Ubuntu

Comment 14

[Dale Harvey (:daleharvey)]

Thanks, will give this one a push to try since it changes dimensions a fair amount, may be some brittle mochitests

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6c1d52bf22
Fix location and search bar height. r=dao

Comment 16

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/fd6c1d52bf22

Comment 17

[Johann Hofmann [:johannh]]

Mozscreenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=0b529227685dc071774480f756bf41dff7068452&newProject=mozilla-central&newRev=baf05f61bc14fdf45511bc1165ce76daa08c5c0f

Comment 18

[Almas Hossain[:mAlmas]]

I have reproduce this bug with Nightly 55.0a1 (2017-05-16) (64-bit) in Windows 10.

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170603030204
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]

Comment 19

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-05-16) on Windows 10, 64 bit.

The fix is now verified on latest Nightly
 
Build ID 	20170606100219
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 20

[Tanvir Rahman]

Sorry, the bug was reproduced on Nightly 55.0a1 (2017-05-16) on Ubuntu 16.04.2 LTS 64-bit

The fix is now verified on latest Nightly on Ubuntu 16.04.2 LTS

Build ID 	20170606100219
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

As per Comment 18 & Comment 19, I am marking this bug as verified fixed.