Closed Bug 1365683 Opened 3 years ago Closed 3 years ago
Increase horizontal margin around the location bar and the search bar
This should help with bug 1365003, which current mockups don't consider (they assume the search bar isn't there and we center the location bar). I also renamed location-search-bar.inc.css to urlbar-searchbar.inc.css since this better matches the names used in our code base.
Accidentally moved the %endif to the wrong place when I rebased.
Summary: Increase margin around the location bar and the search bar → Increase horizontal margin around the location bar and the search bar
Comment on attachment 8868683 [details] [diff] [review] patch v2 Yeh I thought we were getting rid of the search bar so didnt account for it, this looks good cheers
Attachment #8868683 - Flags: review?(dale) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/e2a8479e93e2 Increase horizontal margin around the location bar and the search bar. r=dale
Text size in location and search bar is still too small.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4c50e7d769 followup: move urlbar-searchbar.inc.css include to the right place so that it works for non-Photon
I have reproduced this bug with Nightly 55.0a1 (2017-05-17) (64-bit) on Ubuntu 16.04 64 Bit LTS ! This bug's fix is verified with latest Nightly! Build ID : 20170524100215 User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170524]
You need to log in before you can comment on or make changes to this bug.