Closed
Bug 1365683
Opened 7 years ago
Closed 7 years ago
Increase horizontal margin around the location bar and the search bar
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | verified |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.79 KB,
patch
|
daleharvey
:
review+
|
Details | Diff | Splinter Review |
This should help with bug 1365003, which current mockups don't consider (they assume the search bar isn't there and we center the location bar). I also renamed location-search-bar.inc.css to urlbar-searchbar.inc.css since this better matches the names used in our code base.
Attachment #8868680 -
Flags: review?(dale)
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify+
|
|
Assignee | |
Comment 1•7 years ago
|
||
Accidentally moved the %endif to the wrong place when I rebased.
Attachment #8868680 -
Attachment is obsolete: true
Attachment #8868680 -
Flags: review?(dale)
Attachment #8868683 -
Flags: review?(dale)
|
|
Assignee | |
Updated•7 years ago
|
Summary: Increase margin around the location bar and the search bar → Increase horizontal margin around the location bar and the search bar
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8868683 [details] [diff] [review] patch v2 Yeh I thought we were getting rid of the search bar so didnt account for it, this looks good cheers
Attachment #8868683 -
Flags: review?(dale) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e2a8479e93e2 Increase horizontal margin around the location bar and the search bar. r=dale
|
||
Comment 4•7 years ago
|
||
Text size in location and search bar is still too small.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4c50e7d769 followup: move urlbar-searchbar.inc.css include to the right place so that it works for non-Photon
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e2a8479e93e2 https://hg.mozilla.org/mozilla-central/rev/bf4c50e7d769
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Comment 7•7 years ago
|
||
I have reproduced this bug with Nightly 55.0a1 (2017-05-17) (64-bit) on Ubuntu 16.04 64 Bit LTS ! This bug's fix is verified with latest Nightly! Build ID : 20170524100215 User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170524]
|
|
Assignee | |
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 8•7 years ago
|
||
Screenshots here: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=3801e9bd76ad91b5754faacd3fec9ad4bc3fc782&newProject=mozilla-central&newRev=183c3537157290d7ccef475651b6bc35db914924 along with the changes from bug 1365906.
You need to log in
before you can comment on or make changes to this bug.
Description
•