Increase horizontal margin around the location bar and the search bar

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Theme
VERIFIED FIXED
6 months ago
6 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox55 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 months ago
Created attachment 8868680 [details] [diff] [review]
patch

This should help with bug 1365003, which current mockups don't consider (they assume the search bar isn't there and we center the location bar).

I also renamed location-search-bar.inc.css to urlbar-searchbar.inc.css since this better matches the names used in our code base.
Attachment #8868680 - Flags: review?(dale)
(Assignee)

Updated

6 months ago
Flags: qe-verify+
(Assignee)

Comment 1

6 months ago
Created attachment 8868683 [details] [diff] [review]
patch v2

Accidentally moved the %endif to the wrong place when I rebased.
Attachment #8868680 - Attachment is obsolete: true
Attachment #8868680 - Flags: review?(dale)
Attachment #8868683 - Flags: review?(dale)
(Assignee)

Updated

6 months ago
Summary: Increase margin around the location bar and the search bar → Increase horizontal margin around the location bar and the search bar
Comment on attachment 8868683 [details] [diff] [review]
patch v2

Yeh I thought we were getting rid of the search bar so didnt account for it, this looks good cheers
Attachment #8868683 - Flags: review?(dale) → review+

Comment 3

6 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2a8479e93e2
Increase horizontal margin around the location bar and the search bar. r=dale

Comment 4

6 months ago
Text size in location and search bar is still too small.

Comment 5

6 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4c50e7d769
followup: move urlbar-searchbar.inc.css include to the right place so that it works for non-Photon

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e2a8479e93e2
https://hg.mozilla.org/mozilla-central/rev/bf4c50e7d769
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 7

6 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-05-17) (64-bit) on Ubuntu 16.04 64 Bit LTS !

This bug's fix is verified with latest Nightly!

Build ID   : 20170524100215
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [bugday-20170524]
(Assignee)

Updated

6 months ago
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Screenshots here:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=3801e9bd76ad91b5754faacd3fec9ad4bc3fc782&newProject=mozilla-central&newRev=183c3537157290d7ccef475651b6bc35db914924

along with the changes from bug 1365906.
You need to log in before you can comment on or make changes to this bug.