Wrong message is displayed when searching for something with no search results

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: hani.yacoub, Assigned: evanxd)

Tracking

(Blocks 1 bug)

55 Branch
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox53 unaffected, firefox54 unaffected, firefox55 verified)

Details

(Whiteboard: [photon-preference])

Attachments

(1 attachment)

Reporter

Description

2 years ago
[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences" and click on the "Search" field.
3. Start typing to search for something that doesn't have search results in preferences (e.g custom style).

[Expected result]:
A new page "Search Results" is displayed, showing "Sorry! There are no results in Preferences for "custom style" message.

[Actual result]:
"Sorry! No results were found for "custom style" message is displayed when searching for something with no search results.
Reporter

Updated

2 years ago
Blocks: 1357285
Whiteboard: [photon-preference]
Flags: qe-verify+
Priority: -- → P2
QA Contact: hani.yacoub
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8868489 - Flags: review?(mconley)
Assignee

Comment 3

2 years ago
Hi Mike,

Could you help review the patch?

Thanks.
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8868489 [details]
Bug 1365259 - Update the result not found message.

https://reviewboard.mozilla.org/r/140104/#review143672

Looks good, and matches spec! Thanks!
Attachment #8868489 - Flags: review?(mconley) → review+
Assignee

Comment 6

2 years ago
Thanks for reviewing, Mike. Let's land the patch.
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51dc323da1c3
Update the result not found message. r=mconley
Keywords: checkin-needed

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/51dc323da1c3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Do we care at all about Preferences vs Options (I have no access to specs)? It still seems relevant, e.g. Bug 1344924
Flags: needinfo?(mconley)
Ah, yep, that's a good call flod.

evanxd - can you file a new bug to change that string to "Options" in the Linux / Windows case?
Flags: needinfo?(mconley) → needinfo?(evan)
Assignee

Updated

2 years ago
See Also: → 1366214
Assignee

Comment 11

2 years ago
Sure, Mike. Done.
Flags: needinfo?(evan)
Reporter

Comment 12

2 years ago
Build ID: 20170524030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.