Closed Bug 1365259 Opened 3 years ago Closed 3 years ago
Wrong message is displayed when searching for something with no search results
59 bytes, text/x-review-board-request
[Affected versions]: Nightly 55.0a1 [Affected platforms]: Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12 [Steps to reproduce]: 1. Launch firefox, go to about:config and search for "browser.preferences.search" and set it value to true. 2. Go to "about:preferences" and click on the "Search" field. 3. Start typing to search for something that doesn't have search results in preferences (e.g custom style). [Expected result]: A new page "Search Results" is displayed, showing "Sorry! There are no results in Preferences for "custom style" message. [Actual result]: "Sorry! No results were found for "custom style" message is displayed when searching for something with no search results.
Priority: -- → P2
QA Contact: hani.yacoub
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: P2 → P1
Hi Mike, Could you help review the patch? Thanks.
Comment on attachment 8868489 [details] Bug 1365259 - Update the result not found message. https://reviewboard.mozilla.org/r/140104/#review143672 Looks good, and matches spec! Thanks!
Attachment #8868489 - Flags: review?(mconley) → review+
Thanks for reviewing, Mike. Let's land the patch.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/51dc323da1c3 Update the result not found message. r=mconley
Do we care at all about Preferences vs Options (I have no access to specs)? It still seems relevant, e.g. Bug 1344924
Ah, yep, that's a good call flod. evanxd - can you file a new bug to change that string to "Options" in the Linux / Windows case?
Flags: needinfo?(mconley) → needinfo?(evan)
Sure, Mike. Done.
Build ID: 20170524030204 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.