1365519 - nsUnknownDecoder block off-main thread delivery?

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

nsUnknownDecoder doesn't implement nsIThreadRetargetableStreamListener, so it might block the mNextListener from requesting OMT ODA.

https://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/netwerk/streamconv/converters/nsUnknownDecoder.cpp#120

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We should fix this after PBg-Http is landed in order to trigger HTTP OMT in content process as much as possible.

Comment 2

[Dragana Damjanovic [:dragana]]

I did not know about this bug, but I wanted to fix it with bug 1357678. I was intended to fix all streamListeners in netwerk/streamconv

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: bug_1365519.patch

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=458b93f939c613b33ccc58c97a37e6d2454d6765

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 8879539 [details] [diff] [review]
bug_1365519.patch

Review of attachment 8879539 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/streamconv/converters/nsUnknownDecoder.cpp
@@ +448,2 @@
>    if (channel) {
>      nsresult rv = ConvertEncodedData(aRequest, mBuffer, mBufferLen);

maybe add a short comment that this is always called only on a single thread for one instance of this object

::: netwerk/streamconv/converters/nsUnknownDecoder.h
@@ +135,5 @@
>    bool mRequireHTMLsuffix;
>  
>    nsCString mContentType;
>  
> +  mutable mozilla::Mutex mMutex;

please comment what this syncs

Comment 6

[Dragana Damjanovic [:dragana]]

Attachment: bug_1365519.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4878203823c
Make nsUnknownDecoder nsIThreadRetargetableStreamListener. r=mayhemer

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b4878203823c