Remove b2g codes about parsing mCodecSpecificConfig for mp4v

RESOLVED FIXED in Firefox 55

Status

()

Product:
Core
Component:
Audio/Video: Playback
RESOLVED FIXED
Reported:
11 months ago
Modified:
11 months ago

People

(Reporter: alfredo, Assigned: alfredo)

Tracking

Version:
unspecified
Target:
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.
59 bytes, text/x-review-board-request
jya
: review+
Details | Review
(Assignee)

Description

•
11 months ago 
This is from bug 1153876. It can be removed since there is no b2g.
Comment hidden (mozreview-request)
(Assignee)

Updated

•
11 months ago
Attachment #8868926 - Attachment is obsolete: true
Comment hidden (mozreview-request)

Comment 4

•
11 months ago
mozreview-review 
Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

https://reviewboard.mozilla.org/r/141778/#review145372

::: commit-message-baf05:1
(Diff revision 1)
> +Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya

it would be nice to have both audio and video use the mExtraData field, rather than different name depending of audio or video

::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>  
>    FindData(aMetaData, kKeyAVCC, mExtraData);
> -  if (!mExtraData->Length()) {
> -    if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> -      ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -

what about vp9 in mp4 and other codec?
Attachment #8870313 - Flags: review?(jyavenard) → review+
 (Assignee)

Comment 5

•
11 months ago
mozreview-review 
Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

https://reviewboard.mozilla.org/r/141778/#review145386

::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>  
>    FindData(aMetaData, kKeyAVCC, mExtraData);
> -  if (!mExtraData->Length()) {
> -    if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> -      ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -

I'll file following bugs for that.

Comment 6

•
11 months ago 
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2edb664cb628
remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya

Comment 7

•
11 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/2edb664cb628
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → ayang
 (Assignee)

Updated

•
11 months ago
See Also: → bug 1348212
You need to log in before you can comment on or make changes to this bug.