1365872 - Remove b2g codes about parsing mCodecSpecificConfig for mp4v

Status: RESOLVED FIXED

Description

[Alfredo Yang (:alfredo)]

This is from bug 1153876. It can be removed since there is no b2g.

Comment 1

[Alfredo Yang (:alfredo)]

http://searchfox.org/mozilla-central/rev/f55349994fdac101d121b11dac769f3f17fbec4b/media/libstagefright/binding/DecoderData.cpp#184

Comment 2

[Alfredo Yang (:alfredo)]

Created attachment 8868926 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

Review commit: https://reviewboard.mozilla.org/r/140574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140574/

Comment 3

[Alfredo Yang (:alfredo)]

Created attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

Review commit: https://reviewboard.mozilla.org/r/141778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141778/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

https://reviewboard.mozilla.org/r/141778/#review145372

::: commit-message-baf05:1
(Diff revision 1)
> +Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya

it would be nice to have both audio and video use the mExtraData field, rather than different name depending of audio or video

::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>  
>    FindData(aMetaData, kKeyAVCC, mExtraData);
> -  if (!mExtraData->Length()) {
> -    if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> -      ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -

what about vp9 in mp4 and other codec?

Comment 5

[Alfredo Yang (:alfredo)]

Comment on attachment 8870313 [details]
Bug 1365872 - remove parsing mp4v mCodecSpecificConfig which is for b2g.

https://reviewboard.mozilla.org/r/141778/#review145386

::: media/libstagefright/binding/DecoderData.cpp
(Diff revision 1)
>  
>    FindData(aMetaData, kKeyAVCC, mExtraData);
> -  if (!mExtraData->Length()) {
> -    if (FindData(aMetaData, kKeyESDS, mExtraData)) {
> -      ESDS esds(mExtraData->Elements(), mExtraData->Length());
> -

I'll file following bugs for that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2edb664cb628
remove parsing mp4v mCodecSpecificConfig which is for b2g. r=jya

Comment 7

[Sebastian Hengst [PTO+professional development; back to normal activity 2019-02-25][:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2edb664cb628