1365889 - Get rid of #ifdef in scratchpad

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Alexandre Poirot [:ochameau]]

Scratchpad.xul still uses one ifdef
http://searchfox.org/mozilla-central/source/devtools/client/scratchpad/scratchpad.xul#306
This won't work with the add-on where there is no build step.

This makes most of tests around scratchpad fail with the add-on.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1365889 - Stop using preprocessing in Scratchpad.

Review commit: https://reviewboard.mozilla.org/r/140660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140660/

Comment 2

[Alexandre Poirot [:ochameau]]

It would be easier from code perspective to convert the accessmenu to properties, as we can't access dtd values from JS.
But that would be bad from the localization point of view, so I chose to keep it in the dtd.
That forces me to set both values on the DOM.

Comment 3

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

Comment on attachment 8868984 [details]
Bug 1365889 - Stop using preprocessing in Scratchpad.

https://reviewboard.mozilla.org/r/140660/#review144540

LGTM!

::: devtools/client/scratchpad/scratchpad.js:1746
(Diff revision 1)
>      this._setupPopupShowingListeners();
> +
> +    // Change the accesskey for the help menu as it can be specific on Windows
> +    // some localizations of Windows (ex:french, german) use "?"
> +    //  for the help button in the menubar but Gnome does not.
> +    let helpMenu = document.getElementById("sp-help-menu");

nit: maybe move `let helpMenu [...]` inside of the if statement as it's not used anywhere else.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8868984 [details]
Bug 1365889 - Stop using preprocessing in Scratchpad.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140660/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffeddbfe999a
Stop using preprocessing in Scratchpad. r=jdescottes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ffeddbfe999a