|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Scratchpad.xul still uses one ifdef http://searchfox.org/mozilla-central/source/devtools/client/scratchpad/scratchpad.xul#306 This won't work with the add-on where there is no build step. This makes most of tests around scratchpad fail with the add-on.
It would be easier from code perspective to convert the accessmenu to properties, as we can't access dtd values from JS. But that would be bad from the localization point of view, so I chose to keep it in the dtd. That forces me to set both values on the DOM.
Comment on attachment 8868984 [details] Bug 1365889 - Stop using preprocessing in Scratchpad. https://reviewboard.mozilla.org/r/140660/#review144540 LGTM! ::: devtools/client/scratchpad/scratchpad.js:1746 (Diff revision 1) > this._setupPopupShowingListeners(); > + > + // Change the accesskey for the help menu as it can be specific on Windows > + // some localizations of Windows (ex:french, german) use "?" > + // for the help button in the menubar but Gnome does not. > + let helpMenu = document.getElementById("sp-help-menu"); nit: maybe move `let helpMenu [...]` inside of the if statement as it's not used anywhere else.
Attachment #8868984 - Flags: review?(jdescottes) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ffeddbfe999a Stop using preprocessing in Scratchpad. r=jdescottes
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.