1365980 - Printing Event Invitation incomplete

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Sascha Bertelt]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.114 Safari/537.36 Vivaldi/1.9.818.50

Steps to reproduce:

Installing 52.1.1 on different machines -> same result
Installing previous version -> expected result


Actual results:

When you try to print an event invitation, the event is missing, even in the print preview.
Only the header (from, to, subject et.) is shown.



Expected results:

The header and the event are shown and you can find it on the print.

Comment 1

[Jorg K (CEST = GMT+2)]

I can confirm that when printing a message that contains an event, the event doesn't show up in print preview.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Any error console messages? Can you attach a screenshot?

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: Screenshot showing event in message pane and print preview

No error in the console. I think this is a problem of how the ICS attachment is rendered for printing, as a wild guess, maybe some MIME call not being set up correctly. I've just come across this recently:
https://dxr.mozilla.org/comm-central/rev/9285e79dfd098b4d5e6de6c12550e72c98387ce4/mailnews/mime/src/mimei.cpp#463
Maybe not triggered for printing. Anyway, I could be 500% wrong ;-(

Comment 4

[[:MakeMyDay]]

We had an issue with that in 4.7.*, but this was successfully fixed with bug 1268856, so this has been working again with 4.7.2++ and must be a regression. Have there been any mime handling changed for TB52 in mailnews?

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to [:MakeMyDay] from comment #4)
> Have there been any mime handling changes for TB52 in mailnews?
Yes, plenty:
https://hg.mozilla.org/comm-central/log/tip/mailnews/mime/src/mimemalt.cpp
https://hg.mozilla.org/comm-central/log/tip/mailnews/mime/src/mimei.cpp
https://hg.mozilla.org/comm-central/log/tip/mailnews/mime/src/mimeleaf.cpp

I'm sure Alice can find the regression for us. Alice, please print preview the attached message (from bug 1360155, slightly edited).

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: Event test 3.eml

Comment 7

[Alice0775 White]

(In reply to Jorg K (GMT+2) from comment #5)

> I'm sure Alice can find the regression for us. Alice, please print preview
> the attached message (from bug 1360155, slightly edited).

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=59608977c7bd08fe89b336e382480f9285eff695&tochange=9290eb29cde94f5912fef14d0fa67c445c4f522c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6bdef7ba8b4108a996b9f61ef9f81c5ea6c93017&tochange=12637ae351d64ecbf6b74cdbf26d7eb24ac0f659

Comment 8

[Jorg K (CEST = GMT+2)]

Thanks Alice. Very much appreciated, as always.

Looks like MIME and me didn't break it, but you calendar guys did ;-)

Comment 9

[[:MakeMyDay]]

Attachment: FixInvitationPrinting-v1.diff

Thanks for detectiong the regression range. Yes, my bad. With bug 1225784, I accidentally partly reverted the fix from bug 1268856.

This patch takes care of it.

Comment 10

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/28736b5614d4bb06cb13b386fa4d3cc1e8467418

Comment 11

[Jorg K (CEST = GMT+2)]

Works nicely now, thanks for fixing it quickly!

Comment 12

[Jorg K (CEST = GMT+2)]

Beta (TB 54, Calendar 5.6):
https://hg.mozilla.org/releases/comm-beta/rev/02ee438e62f57d9dcaa8e93a10e3e43f8cc5e098

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr52/rev/c79a466ff923