1366157 - stylo: Implement Window.getDefaultComputedStyle

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

Apparently we failed to remove it in bug 1355683, so Stylo needs to implement it.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1366157 - stylo: Implement getDefaultComputedStyle.

Review commit: https://reviewboard.mozilla.org/r/142188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142188/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: style: Add support for resolving default computed styles.

Review commit: https://reviewboard.mozilla.org/r/142190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142190/

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7df77450e1dffd058ba25f6ce00949bc2e59f932

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8870704 [details]
style: Add support for resolving default computed styles.

https://reviewboard.mozilla.org/r/142190/#review146032

::: servo/components/style/gecko/wrapper.rs:431
(Diff revision 1)
>  
> +    /// Sets the specified element data, return any existing data.
> +    ///
> +    /// Like `ensure_data`, only safe to call with exclusive access to the
> +    /// element.
> +    pub unsafe fn set_data(&self, new_element_data: Option<ElementData>) -> Option<ElementData> {

perhaps `replace_data`? That'd be consistent with the naming in the standard library for similar methods I think.

::: servo/components/style/traversal.rs:627
(Diff revision 1)
> +          F: Fn(E),
> +          G: Fn(E, Option<ElementData>) -> Option<ElementData>,
> +          H: FnOnce(&ElementStyles)
> +{
> +    // Save and clear out element data from the element and its ancestors.
> +    let mut old_data: Vec<(E, Option<ElementData>)> = vec![];

nit: Perhaps a `SmallVec` would be nice to have here.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8870703 [details]
Bug 1366157 - stylo: Implement getDefaultComputedStyle.

https://reviewboard.mozilla.org/r/142188/#review146036

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8870703 [details]
Bug 1366157 - stylo: Implement getDefaultComputedStyle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142188/diff/1-2/

Comment 7

[Cameron McCormack (:heycam)]

https://github.com/servo/servo/pull/17033

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8870703 [details]
Bug 1366157 - stylo: Implement getDefaultComputedStyle.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142188/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ff936cd4cf4
stylo: Implement getDefaultComputedStyle. r=emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02bdc7d39a54
Update expectations. r=me

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ff936cd4cf4
https://hg.mozilla.org/mozilla-central/rev/02bdc7d39a54