1366252 - "Nightly Support" link on "Search Results" page isn't working

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences" and click on the "Search" field.
3. Start typing to search for something that doesn't have search results in preferences (e.g custom style).
4. Click on "Nightly Support" link.

[Expected result]:
"Nightly Support" link should redirect you to "https://support.mozilla.org/en-US/products/firefox/manage-preferences-and-add-ons-firefox?as=u&utm_source=inproduct"

[Actual result]:
"Nightly Support" link on "Search Results" pages isn't working

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

Review commit: https://reviewboard.mozilla.org/r/141484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141484/

Comment 2

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thanks.

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141484/diff/1-2/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

https://reviewboard.mozilla.org/r/141484/#review145994

r=me with the following two changes

::: commit-message-74566:1
(Diff revision 2)
> +Bug 1366252 - Add the Firefox Support link.

This commit message is not descriptive enough. It should read:
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

::: browser/locales/en-US/chrome/browser/preferences/preferences.properties:262
(Diff revision 2)
>  
>  # Search Results Pane
>  # LOCALIZATION NOTE %S will be replaced by the word being searched
>  searchResults.sorryMessage2=Sorry! There are no results in Preferences for “%S”.
>  # LOCALIZATION NOTE %S gets replaced with the browser name
> -searchResults.needHelp=Need help? Visit <html:a id="need-help-link">%S Support</html:a>
> +searchResults.needHelp2=Need help? Visit <html:a id="need-help-link" target="_blank" href="%S">%S Support</html:a>

/browser/base/content/test/static/browser_misused_characters_in_strings.js will need to be updated to change the string exception ID from searchResults.needHelp to searchResults.needHelp2 or the test will fail.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

https://reviewboard.mozilla.org/r/141484/#review146420

r=me with jaws' issues fixed.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

https://reviewboard.mozilla.org/r/141484/#review146858

::: commit-message-74566:1
(Diff revision 2)
> +Bug 1366252 - Add the Firefox Support link.

Sure, let's do it.

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141484/diff/2-3/

Comment 8

[Evan Tseng [:evanxd]]

Updated the patch for review comments. Let's land the patch after the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b0c1d917626

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8fbaa9227896 -d 3a1143c269e5: rebasing 398491:8fbaa9227896 "Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search. r=jaws,mconley" (tip)
merging browser/components/preferences/in-content/findInPage.js
merging browser/locales/en-US/chrome/browser/preferences/preferences.properties
warning: conflicts while merging browser/components/preferences/in-content/findInPage.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8869924 [details]
Bug 1366252 - Include the URL of the support page in the error message of the no-results-found view of about:preferences search.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141484/diff/3-4/

Comment 11

[Evan Tseng [:evanxd]]

Rebased. Let's land the patch.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e392beb6a34
Include the URL of the support page in the error message of the no-results-found view of about:preferences search. r=jaws,mconley

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e392beb6a34

Comment 14

[Francesco Lodolo [:flod]]

 # LOCALIZATION NOTE %S gets replaced with the browser name
searchResults.needHelp2=Need help? Visit <html:a id="need-help-link" target="_blank" href="%S">%S Support</html:a>

I seriously doubt that localization comment is now correct. Please remember to a) update localization comments when you touch a string b) use ordered arguments when there's more than one.

Comment 15

[Almas Hossain[:mAlmas]]

I have reproduce this bug with Nightly 55.0a1 (2017-05-19) (64-bit) in Windows 10.

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170529030204
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0



[bugday-20170531]

Comment 16

[Hani Yacoub, Desktop QA]

Build ID: 20170529030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.