1366371 - size_t threshold = -1 seems suspicious

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Markus Stange [:mstange]]

I didn't catch this in my review in bug 1243846, but I noticed it reading the code again now:

http://searchfox.org/mozilla-central/rev/24c443a440104dabd9447608bd41b8766e8fc2f5/dom/base/DOMIntersectionObserver.cpp#410

We declare the threshold variable as a size_t (which is unsigned), and then later pass it to UpdateIntersectionObservation which takes an int32_t.

If we have no intersection, we will pass -1 here. I think this works, but we should really use a signed type for this variable.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Use signed integer for intersection threshold

Use int32_t for intersection threshold.

Comment 2

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0bbb65d76029df1d046124fb356e81e44bb4ae4

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/173b2aadfbab
Use signed integer for intersection threshold. r=mstange

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/173b2aadfbab