1366498 - Do not fail the build on -Werror=format-overflow for webrtc

Status: RESOLVED INVALID

(Core :: WebRTC, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Breaks the build with gcc 7.1 and --enable-warnings-as-errors

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1366498 - Don't fail the build on -Werror=format-overflow for webrtc

Review commit: https://reviewboard.mozilla.org/r/141310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141310/

Comment 2

[Eric Rescorla (:ekr)]

It seems like it would be better to fix these warnings. Can you post the compiler warnings so we can evaluate them?

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Eric Rescorla (:ekr) from comment #2)
> It seems like it would be better to fix these warnings. Can you post the
> compiler warnings so we can evaluate them?

We'd want to fix the errors for media/webrtc/signaling (that's basically all our code).  media/webrtc/trunk we probably should disable the warning (for now); we could try enabling it again and fixing the bugs (in the upstream repo preferably) after the v57 import (about to land next week) or the import after that.

Nils, who do you think would be a good choice to work on this?

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8869737 [details]
Bug 1366498 - Don't fail the build on -Werror=format-overflow for webrtc

https://reviewboard.mozilla.org/r/141310/#review144894

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Can't reproduce it anymore. Maybe a false positive from gcc as I use a snapshot version. Sorry for the noise :(

Comment 6

[Nils Ohlmeier [:drno]]

I started bug 1369926 for the warnings in nrappkit. nICEr has even more warnings, but I haven't filed a bug for that.