1369926 - Compiler warnings for nrappkit

Status: NEW

(Core :: WebRTC: Networking, enhancement, P4)

Description

[Nils Ohlmeier [:drno]]

Here is a list of compiler warnings for nrappkit which I get on OS X with clang 8.1.0:

18:52.82 warning: media/mtransport/third_party/nrappkit/src/log/r_log.c:199:63 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/log/r_log.c:206:43 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/log/r_log.c:569:41 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/log/r_log.c:587:41 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/c2ru.c:239:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned int'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registry.c:362:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registry.c:579:27 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registry_local.c:885:9 [-Wmacro-redefined] 'NRREGGET' macro redefined
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registry_local.c:978:9 [-Wmacro-redefined] 'NRREGSET' macro redefined
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registrycb.c:106:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registrycb.c:402:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/registry/registrycb.c:425:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'
18:52.82 warning: media/mtransport/third_party/nrappkit/src/util/hex.c:59:14 [-Wsign-compare] comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int'
18:52.85 warning: media/mtransport/third_party/nrappkit/src/util/hex.c:67:14 [-Wsign-compare] comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int'
18:52.85 warning: media/mtransport/third_party/nrappkit/src/util/hex.c:92:14 [-Wsign-compare] comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int'
18:52.85 warning: media/mtransport/third_party/nrappkit/src/util/libekr/r_errors.c:117:19 [-Wsign-compare] comparison of integers of different signs: 'int' and 'unsigned long'

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1369926: fix compiler warnings for nrappkit

Review commit: https://reviewboard.mozilla.org/r/145502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145502/

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.