Closed
Bug 1366507
Opened 8 years ago
Closed 8 years ago
Port Bug 1356244 to C-C [Come up with a shim module that keep firefox green while devtools are removed]
Categories
(Thunderbird :: Installer, enhancement)
Thunderbird
Installer
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
2.47 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
From bug 1356244 comment 0:
Once DevTools are going to be shipped as an add-on, various code in Firefox is still going to depend on devtools, like WebExtension for example.
We still need some code in mozilla-central/Firefox to ease interacting with Devtools. This code should expose whatever API is required by Firefox codebase and react to the installation of the DevTools Add-on. It may also automatically install the add-on under some circonstance.
The main goal of this bug is to introduce this module and keep all tests green in the three following setup:
* with this module (and the related refactoring) on mozilla-central tip,
* same, but with DevTools being stripped from mozilla-central,
* on the incoming DevTools repo, with all the DevTools tests (xpcshell, mochitests), we may move some tests from m-c to devtools, like webextension tests related to devtools APIs.
Keeping mozilla-central tests green while devtools is being removed depends on some other bugs like bug 1356231, bug 1356231 and some other to come. In some cases we have to refactor m-c codebase to just stop depending on devtools.
This bug isn't related to the shim layer that will help web developers automatically install the add-on. Instead, it is focused on the low level shim that keep everything working when we do not have devtools and then install it.
Assignee | ||
Comment 1•8 years ago
|
||
Port to c-c
Comment 2•8 years ago
|
||
Note that bug 1356244 landed:
https://hg.mozilla.org/mozilla-central/rev/e18063b2ed57#l1.35
So I put a print into
comm-central/mozilla/devtools/client/framework/ devtools.js - function DevTools() - to see whether it's executed. It is executed, so we really need to package that stuff.
Richard, you said in a PM that DevTools still work without packaging, but don't you see an error in the console? Something like "DevToolsShim not defined"?
Comment 3•8 years ago
|
||
Comment on attachment 8869755 [details] [diff] [review]
Bug1366507.patch
I convinced myself that we need this.
Attachment #8869755 -
Flags: review?(jorgk) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9285e79dfd098b4d5e6de6c12550e72c98387ce4
I needed to fix the patch before landing it, "browser/" had to be removed.
I landed it since without it we have Xpcshell test failures.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
Assignee | ||
Comment 5•8 years ago
|
||
Good catch. Thank you.
You need to log in
before you can comment on or make changes to this bug.
Description
•