Closed Bug 1366532 Opened 4 years ago Closed 3 years ago

convert uses of "defer" to "new Promise" in client/performance

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: mkohler, Assigned: sreeise)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
wrong bug, sorry.. ignore comment #1
This is a work in progress, there is still one defer missing I can't figure out right now. Will have another look tomorrow.
Unassigning myself as there has been no recent action from my side and I don't see myself doing any action on this for the next few weeks.

Sorry about this, if somebody wants to take this, go for it! :)
Assignee: me → nobody
Status: ASSIGNED → NEW
Priority: -- → P3
SO I would like to work on this bug. I was redirected here from the meta. Can I claim this?

I have the devtools debugger installed on my linux machine, is that all I'll need?
Product: Firefox → DevTools
Just to be sure here, is there anyone still working on this? I don't mind taking it up if not.
Assignee: nobody → reeisesean
Status: NEW → ASSIGNED
Havn't heard anything from previous interest in this bug, so taking it up to work on.
Attachment #8869835 - Attachment is obsolete: true
Attachment #8990289 - Flags: review?(gtatum)
Wanted to note on this as well that there are 4 tests in the patch that are disabled so there was no real way to test them, at least that I am aware of:

browser-perf-recordings-io-03.js
browser-perf-recordings-io-04.js
browser_perf-recordings-io-06.js
browser_timeline-waterfall-workers.js
Hey yeah sorry, I'm not working on this anymore.
(In reply to Michael G Brown from comment #12)
> Hey yeah sorry, I'm not working on this anymore.

Thanks Michael, no worries about it, just wanted to make sure.
Comment on attachment 8990289 [details]
Bug 1366532 - Replaced uses of 'defer' with 'new Promise' in the devtools/client/performance directory.

https://reviewboard.mozilla.org/r/255322/#review262520

This all looks correct to me, and it looks like you have a clean try run. Thanks for the fix. Do you need me to land this, or do you have access?
Attachment #8990289 - Flags: review?(gtatum) → review+
(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #14)
> Comment on attachment 8990289 [details]
> Bug 1366532 - Replaced uses of 'defer' with 'new Promise' in the
> devtools/client/performance directory.
> 
> https://reviewboard.mozilla.org/r/255322/#review262520
> 
> This all looks correct to me, and it looks like you have a clean try run.
> Thanks for the fix. Do you need me to land this, or do you have access?


Awesome, thanks for the review. And yeah I currently do not have access to land patches. If your not busy and want to, then that we be great, but if not it is not a big deal at all I can always just put check-needed on the bug
Not sure if you would see my comment without a need info here, so just in case.
Flags: needinfo?(gtatum)
Gonna go ahead and clear the NI and put checkin-needed just to get this bug out of the way. Thanks again for the review.
Flags: needinfo?(gtatum)
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c7ac628ad88
Replaced uses of 'defer' with 'new Promise' in the devtools/client/performance directory. r=gregtatum
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6c7ac628ad88
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Thanks Sean !
You need to log in before you can comment on or make changes to this bug.