1366532 - convert uses of "defer" to "new Promise" in client/performance

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

Comment 1

[Michael Kohler [:mkohler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26c98a7d6b8054e31167a1d62f5253d2b3c3477c

Comment 2

[Michael Kohler [:mkohler]]

wrong bug, sorry.. ignore comment #1

Comment 3

[Michael Kohler [:mkohler]]

Attachment: WIP: Bug 1366532 - convert uses of "defer" to "new Promise" in client/performance

Review commit: https://reviewboard.mozilla.org/r/141382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141382/

Comment 4

[Michael Kohler [:mkohler]]

This is a work in progress, there is still one defer missing I can't figure out right now. Will have another look tomorrow.

Comment 5

[Michael Kohler [:mkohler]]

Unassigning myself as there has been no recent action from my side and I don't see myself doing any action on this for the next few weeks.

Sorry about this, if somebody wants to take this, go for it! :)

Comment 6

[Michael G Brown]

SO I would like to work on this bug. I was redirected here from the meta. Can I claim this?

I have the devtools debugger installed on my linux machine, is that all I'll need?

Comment 7

[Sean Reeise [:sreeise]]

Just to be sure here, is there anyone still working on this? I don't mind taking it up if not.

Comment 8

[Sean Reeise [:sreeise]]

Havn't heard anything from previous interest in this bug, so taking it up to work on.

Comment 9

[Sean Reeise [:sreeise]]

Attachment: Bug 1366532 - Replaced uses of 'defer' with 'new Promise' in the devtools/client/performance directory.

Review commit: https://reviewboard.mozilla.org/r/255322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255322/

Comment 10

[Sean Reeise [:sreeise]]

Treeherder link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3396f9f813c5001df97d235e94841eeef3e72d91

Comment 11

[Sean Reeise [:sreeise]]

Wanted to note on this as well that there are 4 tests in the patch that are disabled so there was no real way to test them, at least that I am aware of:

browser-perf-recordings-io-03.js
browser-perf-recordings-io-04.js
browser_perf-recordings-io-06.js
browser_timeline-waterfall-workers.js

Comment 12

[Michael G Brown]

Hey yeah sorry, I'm not working on this anymore.

Comment 13

[Sean Reeise [:sreeise]]

(In reply to Michael G Brown from comment #12)
> Hey yeah sorry, I'm not working on this anymore.

Thanks Michael, no worries about it, just wanted to make sure.

Comment 14

[Greg Tatum [:gregtatum]]

Comment on attachment 8990289 [details]
Bug 1366532 - Replaced uses of 'defer' with 'new Promise' in the devtools/client/performance directory.

https://reviewboard.mozilla.org/r/255322/#review262520

This all looks correct to me, and it looks like you have a clean try run. Thanks for the fix. Do you need me to land this, or do you have access?

Comment 15

[Sean Reeise [:sreeise]]

(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #14)
> Comment on attachment 8990289 [details]
> Bug 1366532 - Replaced uses of 'defer' with 'new Promise' in the
> devtools/client/performance directory.
> 
> https://reviewboard.mozilla.org/r/255322/#review262520
> 
> This all looks correct to me, and it looks like you have a clean try run.
> Thanks for the fix. Do you need me to land this, or do you have access?


Awesome, thanks for the review. And yeah I currently do not have access to land patches. If your not busy and want to, then that we be great, but if not it is not a big deal at all I can always just put check-needed on the bug

Comment 16

[Sean Reeise [:sreeise]]

Not sure if you would see my comment without a need info here, so just in case.

Comment 17

[Sean Reeise [:sreeise]]

Gonna go ahead and clear the NI and put checkin-needed just to get this bug out of the way. Thanks again for the review.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c7ac628ad88
Replaced uses of 'defer' with 'new Promise' in the devtools/client/performance directory. r=gregtatum

Comment 19

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6c7ac628ad88

Comment 20

[Julien Wajsberg [:julienw]]

Thanks Sean !