If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Consistently remove the dropdown arrow from all type=menu toolbarbuttons in the navigation toolbar

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Theme
P1
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: dao, Assigned: johannh)

Tracking

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual][p1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
We currently do this only for known built-in buttons. It makes sense to assume that we'll want the same if we add another menu button, and to treat add-on buttons the same way.

Johann, want to take this? It will make bug 1352358 easier.
Flags: needinfo?(jhofmann)

Updated

4 months ago
Flags: qe-verify?
Priority: -- → P2
(Assignee)

Comment 1

4 months ago
Sure.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request)
(Reporter)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8870024 [details]
Bug 1366550 - Hide the dropdown arrow of type=menu and type=panel buttons in the navbar.

https://reviewboard.mozilla.org/r/141546/#review145132

::: browser/themes/shared/toolbarbuttons.inc.css:116
(Diff revision 1)
>    -moz-appearance: none;
>    padding: 0;
>    margin: 0;
>  }
>  
> -#nav-bar .toolbarbutton-1:not([type=menu-button]),
> +#nav-bar .toolbarbutton-1,

Need to keep :not([type=menu-button]) here. type=menu-button is different from type=menu.

::: browser/themes/shared/toolbarbuttons.inc.css:194
(Diff revision 1)
>  #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
>    border-inline-end-style: none;
>  }
>  
> -#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-icon,
> -#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-badge-stack,
> +#nav-bar .toolbarbutton-1[type=menu] > .toolbarbutton-menu-dropmarker,
> +#nav-bar .toolbarbutton-1[type=panel] > .toolbarbutton-menu-dropmarker {

#nav-bar .toolbarbutton-1 > .toolbarbutton-menu-dropmarker
Attachment #8870024 - Flags: review?(dao+bmo) → review+
Comment hidden (mozreview-request)

Comment 5

4 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0e00320b59a
Hide the dropdown arrow of type=menu and type=panel buttons in the navbar. r=dao

Updated

4 months ago
Iteration: --- → 55.6 - May 29
Priority: P2 → P1

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b0e00320b59a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

4 months ago
Flags: qe-verify? → qe-verify-
(Reporter)

Updated

4 months ago
Depends on: 1370503

Comment 7

3 months ago
Out of curiosity, was there a reason to do this only on the nav-bar? What happens if users customize buttons to the tabstrip or bookmarks toolbar?
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 8

3 months ago
(In reply to :Gijs from comment #7)
> Out of curiosity, was there a reason to do this only on the nav-bar? What
> happens if users customize buttons to the tabstrip or bookmarks toolbar?

We only do it where we apply the toolbarbutton-1 styling (otherwise we fall back to native). If/when we make that include the bookmarks toolbar, we should hide the dropmarker there too. The tabs toolbar is included as of <https://hg.mozilla.org/mozilla-central/rev/be624d4f3f132c032429381517a2e736563dac38>.
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.