1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Dão Gottwald [::dao]]

Since we hide the dropmarker arrow, there's no point styling it in the first place.

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

Since we hide the dropmarker arrow, there's no point styling it in the first place.

Review commit: https://reviewboard.mozilla.org/r/146186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146186/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150184

::: browser/themes/shared/toolbarbuttons.inc.css:209
(Diff revision 1)
>  
>  #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
>    border-inline-end-style: none;
>  }
>  
> +.bookmark-item > .toolbarbutton-menu-dropmarker,

If you made this rule apply to the entire PlacesToolbar you could remove these as well:

https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782 (exists on all platforms)

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150184

> If you made this rule apply to the entire PlacesToolbar you could remove these as well:
> 
> https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
> https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782 (exists on all platforms)

Actually I guess that only applies to the #new-tab-button, since that is the only one that can be moved into the bookmarks toolbar. The other rules can probably be removed anyway.

Comment 4

[Dão Gottwald [::dao]]

(In reply to Johann Hofmann [:johannh] from comment #2)
> Comment on attachment 8874802 [details]
> Bug 1370503 - Remove leftover .toolbarbutton-1 >
> .toolbarbutton-menu-dropmarker styling.
> 
> https://reviewboard.mozilla.org/r/146186/#review150184
> 
> ::: browser/themes/shared/toolbarbuttons.inc.css:209
> (Diff revision 1)
> >  
> >  #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
> >    border-inline-end-style: none;
> >  }
> >  
> > +.bookmark-item > .toolbarbutton-menu-dropmarker,
> 
> If you made this rule apply to the entire PlacesToolbar you could remove
> these as well:
> 
> https://searchfox.org/mozilla-central/rev/
> d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
> https://searchfox.org/mozilla-central/rev/
> d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782
> (exists on all platforms)

Nope, toolbarbuttons.inc.css doesn't currently care about toolbarbutton-1 buttons moved to PlacesToolbar, and it shouldn't inconsistently start here.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150398

Ok, but comment 3 still applies, right? You can remove the linked rules that are not about #new-tab-button. In any case, that's just a nit. The rest looks good.

Comment 6

[Dão Gottwald [::dao]]

Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146186/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be624d4f3f13
Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling. r=johannh

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be624d4f3f13