Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual][p3])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Since we hide the dropmarker arrow, there's no point styling it in the first place.
Flags: qe-verify-
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8874802 - Flags: review?(jhofmann)
Iteration: --- → 55.7 - Jun 12

Comment 2

a year ago
mozreview-review
Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150184

::: browser/themes/shared/toolbarbuttons.inc.css:209
(Diff revision 1)
>  
>  #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
>    border-inline-end-style: none;
>  }
>  
> +.bookmark-item > .toolbarbutton-menu-dropmarker,

If you made this rule apply to the entire PlacesToolbar you could remove these as well:

https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782 (exists on all platforms)

Comment 3

a year ago
mozreview-review-reply
Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150184

> If you made this rule apply to the entire PlacesToolbar you could remove these as well:
> 
> https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
> https://searchfox.org/mozilla-central/rev/d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782 (exists on all platforms)

Actually I guess that only applies to the #new-tab-button, since that is the only one that can be moved into the bookmarks toolbar. The other rules can probably be removed anyway.
(Assignee)

Comment 4

a year ago
(In reply to Johann Hofmann [:johannh] from comment #2)
> Comment on attachment 8874802 [details]
> Bug 1370503 - Remove leftover .toolbarbutton-1 >
> .toolbarbutton-menu-dropmarker styling.
> 
> https://reviewboard.mozilla.org/r/146186/#review150184
> 
> ::: browser/themes/shared/toolbarbuttons.inc.css:209
> (Diff revision 1)
> >  
> >  #nav-bar .toolbarbutton-1 > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
> >    border-inline-end-style: none;
> >  }
> >  
> > +.bookmark-item > .toolbarbutton-menu-dropmarker,
> 
> If you made this rule apply to the entire PlacesToolbar you could remove
> these as well:
> 
> https://searchfox.org/mozilla-central/rev/
> d441cb24482c2e5448accaf07379445059937080/browser/base/content/browser.css#143
> https://searchfox.org/mozilla-central/rev/
> d441cb24482c2e5448accaf07379445059937080/browser/themes/osx/browser.css#1782
> (exists on all platforms)

Nope, toolbarbuttons.inc.css doesn't currently care about toolbarbutton-1 buttons moved to PlacesToolbar, and it shouldn't inconsistently start here.

Comment 5

a year ago
mozreview-review
Comment on attachment 8874802 [details]
Bug 1370503 - Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling.

https://reviewboard.mozilla.org/r/146186/#review150398

Ok, but comment 3 still applies, right? You can remove the linked rules that are not about #new-tab-button. In any case, that's just a nit. The rest looks good.
Attachment #8874802 - Flags: review?(jhofmann) → review+
Comment hidden (mozreview-request)

Comment 7

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be624d4f3f13
Remove leftover .toolbarbutton-1 > .toolbarbutton-menu-dropmarker styling. r=johannh

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be624d4f3f13
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.