Closed Bug 1366633 Opened 8 years ago Closed 8 years ago

Saved Logins button is being left aligned

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + verified

People

(Reporter: euthanasia_waltz, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1366633 - Saved Logins button is being left aligned
59 bytes, text/x-review-board-request
dao
: review+
Details
Blocks: 1351867
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
tracking-firefox55: --- → ?
Ever confirmed: true
Flags: needinfo?(rchien)
Keywords: regression
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(rchien) → qe-verify+
Whiteboard: [photon-preference]
Evan, I think this regression was introduced accidentally. Since this is not a big complicated change, could you help me review the patch? thanks.
Blocks: 1357285
Priority: -- → P1
QA Contact: hani.yacoub
Comment on attachment 8870227 [details] Bug 1366633 - Saved Logins button is being left aligned https://reviewboard.mozilla.org/r/141692/#review145654 ::: browser/components/preferences/in-content/privacy.xul:323 (Diff revision 2) > label="&passwordExceptions.label;" > accesskey="&passwordExceptions.accesskey;" > preference="pref.privacy.disable_button.view_passwords_exceptions"/> > </hbox> > <hbox id="showPasswordBox"> > - <hbox id="showPasswordsBox"/> > + <spacer flex="1"/> Please use pack="end" instead of the spacer. r=me with that addressed
Attachment #8870227 - Flags: review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef182af1ccd7 Saved Logins button is being left aligned r=dao
https://hg.mozilla.org/mozilla-central/rev/ef182af1ccd7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduce this bug with Nightly 55.0a1 (2017-05-21) (64-bit) in Windows 10. This bug's fix is verified with latest Nightly 55.0a1 (64-bit). Build ID : 20170524030204 User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170524]
Blocks: 1368890
Build ID: 20170601030206 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: