1366661 - (photon) Light Weight Theme with new awesome bar UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1366661 - Cover a mask on toolbar when light weight theme is applied.

Review commit: https://reviewboard.mozilla.org/r/160322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160322/

Comment 2

[Julian Chu [:walkingice]]

Comment on attachment 8889267 [details]
Bug 1366661 - Cover a mask on toolbar when light weight theme is applied.

https://reviewboard.mozilla.org/r/160322/#review168548

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java:929
(Diff revision 1)
>          if (drawable == null) {
>              return;
>          }
>  
> +        // Add a mask(#B2FFFFFF) over the light weight theme drawable.
> +        drawable.setColorFilter(Color.argb(178, 255, 255, 255), PorterDuff.Mode.SRC_OVER);

is that good to get color from color resource?

Comment 3

[Jing-wei Wu [:jwu]]

Comment on attachment 8889267 [details]
Bug 1366661 - Cover a mask on toolbar when light weight theme is applied.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160322/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e389c2a02012
Cover a mask on toolbar when light weight theme is applied. r=walkingice

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e389c2a02012

Comment 6

[Ioana Chiorean]

Attachment: Themes.png

Pixel Android 7.1 
Nightly 57.0a1 2017-08-08
I was able to go to Add-ons -> Themes and install and preview several ones without any issue

Comment 7

[Ioana Chiorean]

as per last comment