(photon) Light Weight Theme with new awesome bar UI

VERIFIED FIXED in Firefox 57

Status

()

Firefox for Android
General
VERIFIED FIXED
9 months ago
6 months ago

People

(Reporter: wesley_huang, Assigned: jwu)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [FNC][SPT57.1][MVP])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

7 months ago
Assignee: nobody → topwu.tw
Blocks: 1379650
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8889267 [details]
Bug 1366661 - Cover a mask on toolbar when light weight theme is applied.

https://reviewboard.mozilla.org/r/160322/#review168548

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java:929
(Diff revision 1)
>          if (drawable == null) {
>              return;
>          }
>  
> +        // Add a mask(#B2FFFFFF) over the light weight theme drawable.
> +        drawable.setColorFilter(Color.argb(178, 255, 255, 255), PorterDuff.Mode.SRC_OVER);

is that good to get color from color resource?
Attachment #8889267 - Flags: review?(walkingice0204) → review+
Whiteboard: [FNC][SPT_57.1][MVP]
Whiteboard: [FNC][SPT_57.1][MVP] → [FNC][SPT57.1][MVP]
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 4

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e389c2a02012
Cover a mask on toolbar when light weight theme is applied. r=walkingice
Keywords: checkin-needed

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e389c2a02012
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Comment 6

7 months ago
Created attachment 8895391 [details]
Themes.png

Pixel Android 7.1 
Nightly 57.0a1 2017-08-08
I was able to go to Add-ons -> Themes and install and preview several ones without any issue

Comment 7

7 months ago
as per last comment
Status: RESOLVED → VERIFIED

Updated

7 months ago
QA Contact: ioana.chiorean
Depends on: 1389164
You need to log in before you can comment on or make changes to this bug.