1389164 - [photon] Light text in toolbar is unreadable when using dark lightweight theme on Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot

When using a lightweight theme with a black or very dark background color, grey text in the address bar is displayed against a gray background, making it unreadable.

Comment 1

[Jing-wei Wu [:jwu]]

We would use this bug to track the new design of lightweight theme on Photon.

Comment 2

[Oana Horvath [:ohorvath]]

Attachment: Screenshot_20170818-152507.png

Same issue with tab titles on tablets, when applying a dark theme. See screenshot.

Comment 3

[Jing-wei Wu [:jwu]]

Attachment: Bug 1389164 - Support new lightweight theme design on Photon.

We use an extra mask for url bar to make url text more clear.

Review commit: https://reviewboard.mozilla.org/r/172522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172522/

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8901048 [details]
Bug 1389164 - Support new lightweight theme design on Photon.

https://reviewboard.mozilla.org/r/172522/#review177812

Comment 5

[Julian Chu [:walkingice]]

Comment on attachment 8901048 [details]
Bug 1389164 - Support new lightweight theme design on Photon.

https://reviewboard.mozilla.org/r/172522/#review178018

::: mobile/android/base/java/org/mozilla/gecko/lwt/LightweightThemeDrawable.java:37
(Diff revision 1)
>      private final Bitmap mBitmap;
>      private final Resources mResources;
>  
>      private int mStartColor;
>      private int mEndColor;
> +    private boolean mHorizontal;

mHorizontalGradient? and we even don't need this member, if we change to `initializeBitmapShader(final boolean horizontalGradient)`

::: mobile/android/base/java/org/mozilla/gecko/lwt/LightweightThemeDrawable.java:108
(Diff revision 1)
>          mColorPaint = new Paint(mPaint);
>          mColorPaint.setColor(color);
>          mColorPaint.setColorFilter(new PorterDuffColorFilter(filter, PorterDuff.Mode.SRC_OVER));
>      }
>  
>      /**

we should update and move this doc to below `setAlpha(..., ..., ...)`

::: mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java:944
(Diff revision 1)
>          final int color = ContextCompat.getColor(view.getContext(), colorResID);
>  
>          final LightweightThemeDrawable drawable = theme.getColorDrawable(view, color);
>          if (drawable != null) {
> -            drawable.setAlpha(LIGHTWEIGHT_THEME_ALPHA, LIGHTWEIGHT_THEME_ALPHA);
> +            if (HardwareUtils.isTablet()) {
> +                drawable.setAlpha(LIGHTWEIGHT_THEME_INVERT_ALPHA_TABLET, LIGHTWEIGHT_THEME_INVERT_ALPHA_TABLET);

```
final boolean horizontalGradient = !HardwareUtils.isTablet();
drawable.setAlpha(....., horizontalGradient);
```

will it provide more sematic?

Comment 6

[Jing-wei Wu [:jwu]]

Comment on attachment 8901048 [details]
Bug 1389164 - Support new lightweight theme design on Photon.

https://reviewboard.mozilla.org/r/172522/#review178018

> mHorizontalGradient? and we even don't need this member, if we change to `initializeBitmapShader(final boolean horizontalGradient)`

`initializeBitmapShader()` is also called in `onBoundsChange()`, which is a callback function, therefore we cannot pass horizontalGradient as a parameter to it.

Just like mBitmap, mStartColor, mEndColor, etc, mHorizontalGradient is stored as a class field.

Comment 7

[Jing-wei Wu [:jwu]]

Comment on attachment 8901048 [details]
Bug 1389164 - Support new lightweight theme design on Photon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172522/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0e215d6e8fc
Support new lightweight theme design on Photon. r=nechen,walkingice

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a0e215d6e8fc

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed in Nightly 57 (2017-08-29).
Devices:
HTC Nexus 9 (Android 7.1.1)
Prestigio Grace X5 (Android 4.4.2)
Oneplus Two (Android 6.0.1)