Closed Bug 1366673 Opened 7 years ago Closed 7 years ago

(photon) Tab icon motion for adding a new tab

Categories

(Firefox for Android Graveyard :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 verified, firefox57 verified)

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: wesley_huang, Assigned: jwu)

References

Details

User Story

Motion Spec: https://drive.google.com/open?id=0B1V1eo-I8g3dOGd6S2xaYm5XOUk

Attachments

(2 files)

      No description provided.
User Story: (updated)
Assignee: nobody → topwu.tw
Comment on attachment 8881359 [details]
Bug 1366673 - Part 2: Implement new tab counter for visual and animation refresh.

https://reviewboard.mozilla.org/r/152536/#review157696

::: mobile/android/app/src/photon/java/org/mozilla/gecko/toolbar/TabCounter.java
(Diff revision 1)
> -    }
> -
> -    // Alpha animations in editing mode cause action bar corruption on the
> -    // Nexus 7 (bug 961749). As a workaround, skip these animations in editing
> -    // mode.
> -    void onEnterEditingMode() {

Please make sure this method is not used in other flavor before you remove it.
Attachment #8881359 - Flags: review?(cnevinchen) → review+
Comment on attachment 8881358 [details]
Bug 1366673 - Part 1: Duplicate tab counter resources for Australis and Photon.

https://reviewboard.mozilla.org/r/152530/#review157700
Attachment #8881358 - Flags: review?(cnevinchen) → review+
Comment on attachment 8881358 [details]
Bug 1366673 - Part 1: Duplicate tab counter resources for Australis and Photon.

https://reviewboard.mozilla.org/r/152530/#review157788
Attachment #8881358 - Flags: review?(walkingice0204) → review+
Comment on attachment 8881359 [details]
Bug 1366673 - Part 2: Implement new tab counter for visual and animation refresh.

https://reviewboard.mozilla.org/r/152536/#review157794

::: mobile/android/app/src/photon/java/org/mozilla/gecko/toolbar/TabCounter.java:76
(Diff revision 1)
> +
> +        // FadeIn in 66ms, with moveDown2 (52~56, 4 frames).
> +        final ObjectAnimator fadeIn = ObjectAnimator.ofFloat(box, "alpha", 0.01f, 1.0f).setDuration(66);
> +
> +        // Move down on y-axis, from -1.0 to 2.7 in 116ms, after moveDown2 (59~66, 7 frames).
> +        final ObjectAnimator moveDown3 = ObjectAnimator.ofFloat(box, "translationY", -1.0f,  2.7f).setDuration(116);

in Android Studio, use 'Ctrl + Alt + L' will find there is one more extra space here

::: mobile/android/app/src/photon/java/org/mozilla/gecko/toolbar/TabCounter.java:175
(Diff revision 1)
> -        // Set In value, trigger animation to Out value
> -        setCurrentText(formatForDisplay(mCount));
> -        setText(formatForDisplay(count));
>  
> -        mCount = count;
> +        // Trigger animation
> +        animationSet.start();

for consistent, maybe `this.animationSet.start()`?

::: mobile/android/app/src/photon/res/drawable/tabs_counter_bar.xml:4
(Diff revision 1)
> +<?xml version="1.0" encoding="utf-8"?>
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +      - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

it seems redundant space here

::: mobile/android/app/src/photon/res/drawable/tabs_counter_box.xml:4
(Diff revision 1)
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +      - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

it seems redundant space here
Attachment #8881359 - Flags: review?(walkingice0204) → review+
Comment on attachment 8881359 [details]
Bug 1366673 - Part 2: Implement new tab counter for visual and animation refresh.

https://reviewboard.mozilla.org/r/152536/#review157696

> Please make sure this method is not used in other flavor before you remove it.

This method isn't called anymore in Australis, remove it in Photon to keep code clean.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/88f74c51d18c
Part 1: Duplicate tab counter resources for Australis and Photon. r=nechen,walkingice
https://hg.mozilla.org/integration/autoland/rev/3e33da82b722
Part 2: Implement new tab counter for visual and animation refresh. r=nechen,walkingice
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/88f74c51d18c
https://hg.mozilla.org/mozilla-central/rev/3e33da82b722
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Blocks: 1379650
Blocks: 1378032
Pixel Android 7.1 
Nightly 57.0a1 2017-08-08
The animation is pretty fast in my case but it behaves properly 

Please see video: https://youtu.be/yf39v30_ccY
Status: RESOLVED → VERIFIED
QA Contact: ioana.chiorean
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: