1378032 - (photon) Disable setTabsCounterPrivateMode in tablet

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jing-wei Wu [:jwu]]

In Photon, TabCounter has a new design and implementation and handle itself private mode visual refresh by calling `TabCounter#setPrivateMode(boolean)`.

So `BrowserToolbarTabletBase#setTabsCounterPrivateMode(boolean, PorterDuffColorFilter)` should only be called in Australis, instead of Photon.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1378032 - Don't call setTabsCounterPrivateMode on Tablet in Photon.

In Photon, TabCounter has a new design and implementation which handles itself
private mode visual refresh by calling `TabCounter#setPrivateMode(boolean)`.

So we shouldn't call setTabsCounterPrivateMode anymore in BrowserToolbarTabletBase.

Review commit: https://reviewboard.mozilla.org/r/154098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154098/

Comment 2

[Julian Chu [:walkingice]]

Comment on attachment 8883159 [details]
Bug 1378032 - Don't call setTabsCounterPrivateMode on Tablet in Photon.

https://reviewboard.mozilla.org/r/154098/#review159586

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22ef5b5f017f
Don't call setTabsCounterPrivateMode on Tablet in Photon. r=walkingice

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22ef5b5f017f

Comment 5

[Ioana Chiorean]

Code changes applied.