1366738 - Implement [LegacyWindowAlias] extended attribute (for WebKitCSSMatrix, webkitURL)

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement, P3)

Description

[Simon Pieters [:zcorpan]]

Background:
https://github.com/heycam/webidl/issues/362

Change for WebIDL:
https://github.com/heycam/webidl/pull/364
https://github.com/w3c/web-platform-tests/pull/5966

Change for Geometry APIs (for WebKitCSSMatrix):
https://github.com/w3c/fxtf-drafts/pull/167
https://github.com/w3c/web-platform-tests/pull/5991

Gecko bug for webkitURL:
https://bugzilla.mozilla.org/show_bug.cgi?id=1366734

Comment 1

[Andrew Overholt [:overholt]]

Should we do this?

Comment 2

[Andrea Marchesini [:baku]]

Yes, we should but it requires an important change in the WebIDL codegen.
A temporary solution would be use NamedConstructor as discussed here: https://github.com/heycam/webidl/issues/362#issuecomment-302044931

Comment 3

[Anne (:annevk)]

Andrea and I discussed this and it doesn't seem important to tackle this before Firefox 57, especially as bz said it would be non-trivial.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1366738: Implement [LegacyWindowAlias]

Add [LegacyWindowAlias] extended attribute support for WebKitCSSMatrix and webkitURL.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/509af1e0771d
Implement [LegacyWindowAlias] r=bzbarsky

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset 509af1e0771d for causing failures in test_WebKitCSSMatrix.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/a70f62521b875857e709f4120006ac2429c869c2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=509af1e0771d619a0b6d73bffec0583f4f0db9a9&tochange=a70f62521b875857e709f4120006ac2429c869c2&searchStr=mochitest&selectedJob=254553208

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254553208&repo=autoland&lineNumber=32339

[task 2019-07-03T07:10:30.318Z] 07:10:30 INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_WebKitCSSMatrix.html | Test that inverting an invertible matrix throws. - Test that inverting an invertible matrix throws.: assert_throws: Inverting an invertible matrix should throw. function "function() { m.inverse(); }" did not throw
[task 2019-07-03T07:10:30.318Z] 07:10:30 INFO - TEST-PASS | dom/tests/mochitest/general/test_WebKitCSSMatrix.html | Test for WebKitCSSMatrix - Test for WebKitCSSMatrix: Elided 4 passes or known failures.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a618b9ef5080
Implement [LegacyWindowAlias] r=bzbarsky

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a618b9ef5080

Comment 9

[Eric Shepherd [:sheppy]]

After review, I do not believe anything here reaches the level of needing to be documented on MDN. If anyone can think of a reason that wouldn't be true, let me know.

Comment 10

[Simon Pieters [:zcorpan]]

https://developer.mozilla.org/en-US/docs/Web/API/CSSMatrix

I think this should redirect to https://developer.mozilla.org/en-US/docs/Web/API/DOMMatrix and this should say that SVGMatrix and WebKitCSSMatrix are legacy aliases to DOMMatrix in a Window context. (Though SVGMatrix is not yet implemented as an alias.) Recommend using DOMMatrix instead of WebKitCSSMatrix.

https://developer.mozilla.org/en-US/docs/Web/API/URL could say that webkitURL exists as a legacy alias in a Window context. Recommend using URL instead.

Comment 12

[Simon Pieters [:zcorpan]]

Adding back dev-doc-needed for my above comment

Comment 13

[Simon Pieters [:zcorpan]]

It looks like my suggestion above have been implemented for https://developer.mozilla.org/en-US/docs/Web/API/DOMMatrix .

I created https://github.com/mdn/content/pull/31015 for webkitURL.