1560480 - DOMMatrix.prototype.rotate() doesn't align with the spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

https://github.com/w3c/fxtf-drafts/commit/430bc88c806091a93aa51a4a3f6c04be7639aa2e

The spec changed in 2016 to support 3D rotation without translation but the Firefox implementation only supports 2D rotation+translation.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Example:

new DOMMatrix([1,2,3,4,5,6]).rotate(6,6,6).is2D // expected `false`, actual `true`

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1560480: Align DOMMatrix rotate*() with the spec

Supports 3D rotation as the spec does.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb9f7df3f736
Align DOMMatrix rotate*() with the spec r=bzbarsky

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb9f7df3f736

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17698 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged