1366773 - Move buffer argument from StartIncrementalEncoding to FinishIncrementalEncoding.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Nicolas B. Pierron [:nbp] {away}]

Currently the buffer given as argument to the XDRIncrementalEncoder is only used to append data into when running the linearize method.  Having this argument held by the XDRIncrementalEncoder pose some issues as we keep a reference to a dangling pointer.

By moving it to the FinishIncrementalEncoding / linearize functions, we no longer have to question this clean-up & lifetime issues.  Also, this simplify the nsJSUtils interface, as we do not have to pass the TranscodeBuffer as argument of the ExecutionContext anymore. (which simplifies Bug 1364117)

Comment 1

[Nicolas B. Pierron [:nbp] {away}]

Attachment: Move buffer argument from JS::StartIncrementalEncoding to JS::FinishIncrementalEncoding.

This patch changes the JS API added to use the XDR incremental encoder, and
update its uses, such as the code added in Bug 900784.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8870039 [details] [diff] [review]
Move buffer argument from JS::StartIncrementalEncoding to JS::FinishIncrementalEncoding.

Review of attachment 8870039 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/script/ScriptLoader.cpp
@@ +2182,5 @@
>    TRACE_FOR_TEST_NONE(aRequest->mElement, "scriptloader_bytecode_saved");
>  }
>  
>  void
>  ScriptLoader::GiveUpBytecodeEncoding()

I'd love for the duplication of the draining while loop below to be pulled out, but I'm not sure if it's worth it. It's not required for this bug, but maybe something to think about.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3967231c7021
Move buffer argument from JS::StartIncrementalEncoding to JS::FinishIncrementalEncoding. r=mrbkap,shu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ef50a79731
Add explicit keyword in front of XDRIncrementalEncoder constructor. r=me on a CLOSED TREE

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3967231c7021
https://hg.mozilla.org/mozilla-central/rev/b5ef50a79731