1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Brian Grinstead [:bgrins]]

From: https://bugzilla.mozilla.org/show_bug.cgi?id=1355331#c43.  If the sidebar is moved to the right the toolbar icon could show the sidebar on the right, and vice versa if it's on the left.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;

Review commit: https://reviewboard.mozilla.org/r/152886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152886/

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: sidebar-toolbar-position-flip.gif

Comment 3

[:Gijs (he/him)]

Comment on attachment 8881809 [details]
Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;

https://reviewboard.mozilla.org/r/152886/#review158018

::: browser/themes/shared/toolbarbutton-icons.inc.css:200
(Diff revision 1)
>  
>  #sidebar-button[cui-areatype="toolbar"] {
>    list-style-image: url("chrome://browser/skin/sidebars.svg");
>  }
>  
> +#sidebar-button[cui-areatype="toolbar"]:not([positionend]) {

This looks OK, but I think this rule needs updating to also include directionality. That is, in RTL, the non-end position should have the inverted icon, and vice versa.

With that, r=me



(Stealing from Mike, who already has a bunch of my reviews to go through, seeing as my queue is empty.)

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8881809 [details]
Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152886/diff/1-2/

Comment 5

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d1d7cfe2519ab20cdc679c1d33c3a41efa27c07

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e311e58d0ce0
Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e311e58d0ce0

Comment 8

[Azmina]

I have seen this "Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser" feature has been implemented with Latest Nightly 56.0a1.

Build ID : 20170703030203
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 9

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=9af23c413a1f8d337b19b4f8450e241e91b71136&newProject=mozilla-central&newRev=d2aff6fc075dc4a0e5ca5b4cf7d530979942d4b4