Closed Bug 1366851 Opened 7 years ago Closed 7 years ago

Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Status
firefox56 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(2 files)

From: https://bugzilla.mozilla.org/show_bug.cgi?id=1355331#c43.  If the sidebar is moved to the right the toolbar icon could show the sidebar on the right, and vice versa if it's on the left.
Flags: qe-verify?
Priority: -- → P2
Priority: P2 → P3
Whiteboard: [photon-structure] → [reserve-photon-structure]
See Also: → 1370545
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8881809 - Flags: review?(mdeboer) → review?(gijskruitbosch+bugs)
Comment on attachment 8881809 [details]
Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;

https://reviewboard.mozilla.org/r/152886/#review158018

::: browser/themes/shared/toolbarbutton-icons.inc.css:200
(Diff revision 1)
>  
>  #sidebar-button[cui-areatype="toolbar"] {
>    list-style-image: url("chrome://browser/skin/sidebars.svg");
>  }
>  
> +#sidebar-button[cui-areatype="toolbar"]:not([positionend]) {

This looks OK, but I think this rule needs updating to also include directionality. That is, in RTL, the non-end position should have the inverted icon, and vice versa.

With that, r=me



(Stealing from Mike, who already has a bunch of my reviews to go through, seeing as my queue is empty.)
Attachment #8881809 - Flags: review?(gijskruitbosch+bugs) → review+
Priority: P3 → P1
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e311e58d0ce0
Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs
https://hg.mozilla.org/mozilla-central/rev/e311e58d0ce0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Iteration: --- → 56.2 - Jul 10
Depends on: 1377551
I have seen this "Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser" feature has been implemented with Latest Nightly 56.0a1.

Build ID : 20170703030203
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170628]
Depends on: 1386361
Depends on: 1391549
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.