136690 - inconsistency in the fileversion info

Status: RESOLVED WONTFIX

(SeaMonkey :: Build Config, defect, P4)

Description

[Henrik Gemal]

the new version information in the file properties is inconsistent with the old 
stuff found in some other files:
check the new fileversioninfo in fx "jpeg3250.dll" and compare it to 
fileversioninfo found in "npnul32.dll" or "SETUP.EXE"

Comment 1

[hacker formerly known as [e-mail]]

-> aki

Comment 2

[Aki Sasaki]

i can't seem to find the jpeg3250.dll file, but I'm guessing that the one that
doesn't say 0.0.0.0 has a RESFILE declared in makefile.win and/or Makefile.in...
RESFILE will override the auto-version stuff.

Comment 3

[Henrik Gemal]

in inconsistency is because the versioninfo of fx npnul32.dll is defined in:
http://lxr.mozilla.org/seamonkey/source/modules/plugin/samples/default/windows/npnul32.rc#75

all the other dll's get theire versioninfo from the perl script

Comment 4

[Aki Sasaki]

adding cc's

Comment 5

[Aki Sasaki]

ok.  the fix is simple:  cvs rm the .rc file, and remove the RESFILE line in the
makefiles.

however, *whether* we want to do this isn't certain... perhaps there's a reason
why we're versioning these with specific version numbers.

Comment 6

[Peter Lubczynski]

um...plugins need that rc file for meta data.

Comment 7

[Aki Sasaki]

so the autoversion .rc file won't do?  if so, then we need to keep it there and
mark this won'tfix.

also need to check on setup.exe's .rc file.

Comment 8

[Peter Lubczynski]

The version info is probably not important to us but we NEED the other data in
the rc file. Is the script capable of merging rc files?

Comment 9

[Aki Sasaki]

yes... i'll submit a patch.

Comment 10

[Jon Granrose]

engineer gone, wontfix.  reopen and reassign to yourself if this is something
you want to do.