1366915 - Change async pipeline id allocation

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

By Bug 1345054 Comment 19, it became clear that current async pipeline id allocation caused reftest failures.

pipeline id allocation often did not happen before reftest.

Comment 1

[Sotaro Ikeda [:sotaro]]

There seems 3 ways to address the problem.
[1] Share id name space between layers id(pipeline id) and external image id
[2] Split layers id and pipeline id
[3] Wait async pipeline id allocation before reftest.

[3] seems not good approach. [2] was already rejected by Bug 1358014 Comment 10. Then this bug is going to seek [3].

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove pipeline id allocation with IPC MozPromise

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make CompositorBridgeChild allocate pipeline id for async image pipeline

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> There seems 3 ways to address the problem.
> [1] Share id name space between layers id(pipeline id) and external image id
> [2] Split layers id and pipeline id
> [3] Wait async pipeline id allocation before reftest.
> 
> [3] seems not good approach. [2] was already rejected by Bug 1358014 Comment
> 10. Then this bug is going to seek [3].

I don't understand this comment. Specially the last line, you say [3] is not a good approach and then you say you're going to do [3]. Did you mean [1] is not a good approach? I also don't really understand the problem that you're trying to solve here - all I can figure out is that the async-ness of the pipeline id allocation is somehow causing a problem but I don't understand how or why. Maybe nical would be a better reviewer for this.

Comment 5

[Sotaro Ikeda [:sotaro]]

Thanks, I am going to ask nical for a review.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make CompositorBridgeChild allocate pipeline id for async image pipeline

Rebased.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/9fb4a2607ce1
part 1 - Remove pipeline id allocation with IPC MozPromise r=nical
https://hg.mozilla.org/projects/graphics/rev/392436e4adff
part 2 - Make CompositorBridgeChild allocate pipeline id for async image pipeline r=nical

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9fb4a2607ce1
https://hg.mozilla.org/mozilla-central/rev/392436e4adff