Change async pipeline id allocation

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

By Bug 1345054 Comment 19, it became clear that current async pipeline id allocation caused reftest failures.

pipeline id allocation often did not happen before reftest.
Blocks: 1345054
Assignee: nobody → sotaro.ikeda.g
There seems 3 ways to address the problem.
[1] Share id name space between layers id(pipeline id) and external image id
[2] Split layers id and pipeline id
[3] Wait async pipeline id allocation before reftest.

[3] seems not good approach. [2] was already rejected by Bug 1358014 Comment 10. Then this bug is going to seek [3].
Depends on: 1366931
Attachment #8870246 - Flags: review?(bugmail)
Attachment #8870247 - Flags: review?(bugmail)
(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> There seems 3 ways to address the problem.
> [1] Share id name space between layers id(pipeline id) and external image id
> [2] Split layers id and pipeline id
> [3] Wait async pipeline id allocation before reftest.
> 
> [3] seems not good approach. [2] was already rejected by Bug 1358014 Comment
> 10. Then this bug is going to seek [3].

I don't understand this comment. Specially the last line, you say [3] is not a good approach and then you say you're going to do [3]. Did you mean [1] is not a good approach? I also don't really understand the problem that you're trying to solve here - all I can figure out is that the async-ness of the pipeline id allocation is somehow causing a problem but I don't understand how or why. Maybe nical would be a better reviewer for this.
Attachment #8870246 - Flags: review?(bugmail)
Attachment #8870247 - Flags: review?(bugmail)
Thanks, I am going to ask nical for a review.
Attachment #8870246 - Flags: review?(nical.bugzilla)
Attachment #8870247 - Flags: review?(nical.bugzilla)
Attachment #8870247 - Flags: review?(nical.bugzilla) → review+
Attachment #8870246 - Flags: review?(nical.bugzilla) → review+
Attachment #8872477 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9fb4a2607ce1
part 1 - Remove pipeline id allocation with IPC MozPromise r=nical
https://hg.mozilla.org/projects/graphics/rev/392436e4adff
part 2 - Make CompositorBridgeChild allocate pipeline id for async image pipeline r=nical
https://hg.mozilla.org/mozilla-central/rev/9fb4a2607ce1
https://hg.mozilla.org/mozilla-central/rev/392436e4adff
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1369074
You need to log in before you can comment on or make changes to this bug.