1366920 - SafeBrowinsg V4 only in nightly 56

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Dimi Lee [:dimi]]

According to our roll out plan for SafeBrowsing V4[1], we will disable V2 and use V4 only for browsing protection in Nightly 56(2017-06-12).

[1] https://wiki.mozilla.org/Security/Safe_Browsing/V4_Implementation#M7_.282017.2F6.2F12.29

Comment 1

[Dimi Lee [:dimi]]

Hi francois,
Since we are all in Taipei this week, do you think we should talk about "if we are ready for this"? or is there any bug blocks this one?

Comment 2

[Dimi Lee [:dimi]]

we will enable this on 19 June.

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1366920 - SafeBrowinsg V4 only in 56.

Review commit: https://reviewboard.mozilla.org/r/147920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147920/

Comment 4

[François Marier [:francois]]

Comment on attachment 8876592 [details]
Bug 1366920 - SafeBrowinsg V4 only in 56.

https://reviewboard.mozilla.org/r/147920/#review152662

At the weekly meeting, we decided to let V4 ride the trains.

So instead of this patch, let's remove the `#ifdef` and move Desktop (but not Fennec) to V4 only.

Comment 5

[Dimi Lee [:dimi]]

Comment on attachment 8876592 [details]
Bug 1366920 - SafeBrowinsg V4 only in 56.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147920/diff/1-2/

Comment 6

[François Marier [:francois]]

Comment on attachment 8876592 [details]
Bug 1366920 - SafeBrowinsg V4 only in 56.

https://reviewboard.mozilla.org/r/147920/#review153272

\o/

Comment 7

[Dimi Lee [:dimi]]

Comment on attachment 8876592 [details]
Bug 1366920 - SafeBrowinsg V4 only in 56.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/147920/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7f1511115e9
SafeBrowinsg V4 only in 56. r=francois

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7f1511115e9