1367022 - Question mark icon size should match the spec

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Hani Yacoub, Desktop QA]

Attachment: Question size.png

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Ubuntu 16.10

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences".
3. Inspect element "Question mark" icon beside "Firefox/Nightly Support".

[Expected result]:
Question mark icon size should match the spec.
The size should be 14x14 px.

[Actual result]:
Question mark icon size is defferenct than the spec.
The size is 24x24px.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Hani,

I've confirmed the question mark icon size is correct with 14 x 14 px. (which is background-size: contain in html:a element). The devtools inspector shows the real image size of help-glyph.svg but it's not the computed size. 

Unfortunately, I can't figure out how to inspect the displayed image size in devtools inspector. There might be some techniques to get the displayed size via Javascript but it's a little bit complicated. Let's assume background-size: contain works properly so that the image size will fit the height of html:a itself (14px).

I'd like to close this issue but feel free to inform me if you have any question. Thanks!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Should be INVALID per comment 1.

Comment 3

[Francis Lee [:frlee]]

remove whiteboard tag due to its INVALID

Comment 4

[Hani Yacoub, Desktop QA]

I wasn't sure if this was the correct way to inspect the size of the question mark icon, i'll mark this as pass in the tests.

And I also couldn't figure out how to verify the question mark icon fill, Firefox support text-area and the distances between "Firefox/Nightly support", "?" and the button left corner as it's indicated the the spec.
Do you know how can I find if they matches the spec?

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Good question! Unfortunately, there are a few ruler addons which are able to measure the distances between elements, but they don't work in about:preferences as well as all in-content pages (e.g. about:addons).

Otherwise you can screenshot the browser and then try to match visual spec.