Closed Bug 1367286 Opened 3 years ago Closed 3 years ago

Remove preference "dom.userHTMLBindings.uri"

Categories

(Core :: XBL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

Per bug 1363640 comment 29, in practice it's unlikely someone ever uses  "dom.userHTMLBindings.uri" preference [1]. We should remove it.

[1] http://searchfox.org/mozilla-central/rev/2933592c4a01b634ab53315ce2d0e43fccb82181/dom/xbl/nsXBLWindowKeyHandler.cpp#115
Boris, I guess you mean "remove the ability of loading user binding" in [1], not only just the preference, right?

[1] http://searchfox.org/mozilla-central/rev/2933592c4a01b634ab53315ce2d0e43fccb82181/dom/xbl/nsXBLWindowKeyHandler.cpp#114-127
Flags: needinfo?(bzbarsky)
Yeah, I think we can just remove that whole bit.
Flags: needinfo?(bzbarsky)
Boris, perhaps you'd want to review this?
Flags: needinfo?(bzbarsky)
Comment on attachment 8870920 [details]
Bug 1367286 - Remove loading user html binding via "dom.userHTMLBindings.uri".

https://reviewboard.mozilla.org/r/142490/#review146080

r=me
Attachment #8870920 - Flags: review+
Flags: needinfo?(bzbarsky)
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8d146db72f5
Remove loading user html binding via "dom.userHTMLBindings.uri". r=bz
https://hg.mozilla.org/mozilla-central/rev/b8d146db72f5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.