1367299 - stylo: Serialization is different for -webkit-radial-gradient

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

For: -webkit-radial-gradient(contain, red, blue)
gecko -> radial-gradient(closest-side, red, blue)
stylo -> -webkit-radial-gradient(center center, contain, red, blue)

I have no idea which is expected... I suspect stylo one.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

It seems different browsers give different answer for this:
gecko: radial-gradient(closest-side, red, blue)
stylo: -webkit-radial-gradient(center center, contain, red, blue)
blink: -webkit-radial-gradient(center, ellipse contain, red, blue)
edge : -webkit-radial-gradient(contain, red, blue)

I guess all of them are effectively identical.

I tried to unconditionally set cssGradient->mIsLegacySyntax if there is webkit-prefix, but it seems the serialization code in nsCSSValue doesn't handle this case correctly, and generates "-webkit-radial-gradient(closest-side, red, blue)", which is probably invalid as a legacy syntax.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Bug 1380259 fixes the serialization differences for computed values, but not for specified values. I am reopening this bug to track the work required to fix this for specified values.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I'll take care of this.

Setting P1 because it is the last blocker for enabling more mochitests.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1367299 - Allow -webkit-radial-gradient to be serialized in different way with stylo.

Review commit: https://reviewboard.mozilla.org/r/164812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164812/

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8893690 [details]
Bug 1367299 - Allow -webkit-radial-gradient to be serialized in different way with stylo.

https://reviewboard.mozilla.org/r/164812/#review170414

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4289bf021340
Allow -webkit-radial-gradient to be serialized in different way with stylo. r=dholbert

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4289bf021340