1367315 - stylo: Parameter of :dir() pseudo-class should be case-insensitive and it shouldn't accept string

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently, ":dir(Ltr)" matches elements in Gecko, but not Stylo, while ":dir('ltr')" matches elements in Stylo, but not Gecko.

It is clear that accepting string in this case is not expected, while it is not clear to me whether the identifier inside should be case-sensitive from the spec. I think in general we don't treat this kind of keywords case-sensitive, so Gecko's approach seems to make more sense.

Relevant spec: https://drafts.csswg.org/selectors-4/#the-dir-pseudo

Other browsers haven't implemented this pseudo-class.

Comment 1

[Matt Brubeck (:mbrubeck)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e55de538ddf4b302dc01308d95bac4a903718c91

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1367315 - stylo: Make :dir argument a case-insensitive identifier.

Review commit: https://reviewboard.mozilla.org/r/145902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145902/

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: Bug 1367315 - stylo: Update :dir selector test failures.

Review commit: https://reviewboard.mozilla.org/r/145904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145904/

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8874545 [details]
Bug 1367315 - stylo: Make :dir argument a case-insensitive identifier.

https://reviewboard.mozilla.org/r/145902/#review149840

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8874546 [details]
Bug 1367315 - stylo: Update :dir selector test failures.

https://reviewboard.mozilla.org/r/145904/#review149842

Comment 6

[Matt Brubeck (:mbrubeck)]

https://github.com/servo/servo/pull/17174

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f48933c5555
stylo: Update :dir selector test failures. r=Manishearth

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2f48933c5555