Closed Bug 1367315 Opened 2 years ago Closed 2 years ago

stylo: Parameter of :dir() pseudo-class should be case-insensitive and it shouldn't accept string

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: mbrubeck)

References

Details

Attachments

(2 files)

Currently, ":dir(Ltr)" matches elements in Gecko, but not Stylo, while ":dir('ltr')" matches elements in Stylo, but not Gecko.

It is clear that accepting string in this case is not expected, while it is not clear to me whether the identifier inside should be case-sensitive from the spec. I think in general we don't treat this kind of keywords case-sensitive, so Gecko's approach seems to make more sense.

Relevant spec: https://drafts.csswg.org/selectors-4/#the-dir-pseudo

Other browsers haven't implemented this pseudo-class.
Priority: -- → P2
Assignee: nobody → mbrubeck
Comment on attachment 8874545 [details]
Bug 1367315 - stylo: Make :dir argument a case-insensitive identifier.

https://reviewboard.mozilla.org/r/145902/#review149840
Attachment #8874545 - Flags: review?(manishearth) → review+
Comment on attachment 8874546 [details]
Bug 1367315 - stylo: Update :dir selector test failures.

https://reviewboard.mozilla.org/r/145904/#review149842
Attachment #8874546 - Flags: review?(manishearth) → review+
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f48933c5555
stylo: Update :dir selector test failures. r=Manishearth
https://hg.mozilla.org/mozilla-central/rev/2f48933c5555
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.