1367349 - Search results matches in a tooltip pointing at buttons are still displayed even after clicking on any of the preferences category

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: search_results.png

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms:  Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences".
3. Start typing to search for something (e.g default).
4. Click on "General".

[Expected result]:
Search results should be deleted after clicking on any preferences category.

[Actual result]:
Search results matches in a tooltip are still displayed even after clicking on any of the preferences category.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review commit: https://reviewboard.mozilla.org/r/143116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143116/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143116/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thanks.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

https://reviewboard.mozilla.org/r/143116/#review146994

Seems okay - just need to fix a typo in the function name. Thanks!

::: browser/components/preferences/in-content/findInPage.js:368
(Diff revision 2)
> +  },
> +
> +  /**
> +   * Remove all search tooltips that were created.
> +   */
> +  removeAllSearchTooltops() {

Nit: removeAllSearchTooltops -> removeAllSearchTooltips

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

https://reviewboard.mozilla.org/r/143116/#review147000

::: browser/components/preferences/in-content/findInPage.js:368
(Diff revision 2)
> +  },
> +
> +  /**
> +   * Remove all search tooltips that were created.
> +   */
> +  removeAllSearchTooltops() {

Wrong spelling. Let's fix it.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143116/diff/2-3/

Comment 7

[Evan Tseng [:evanxd]]

Thanks for reviewing, Mike. I've updated the patch for the review comment.

Patch will be landed after the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=117b09db81d8

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143116/diff/3-4/

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143116/diff/4-5/

Comment 11

[Evan Tseng [:evanxd]]

Rebased. Let's land the patch after the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5643e2f5bb67

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8871624 [details]
Bug 1367349 - Remove all tooltips after clicking on a preferences category.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143116/diff/5-6/

Comment 13

[Evan Tseng [:evanxd]]

There are many test failures in the previous try. Rabase and run again[1].

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=68e02f46fba4

Comment 14

[Evan Tseng [:evanxd]]

The try at Comment 13 is good. Let's land the patch.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2109d6a6d1c8
Remove all tooltips after clicking on a preferences category. r=mconley

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2109d6a6d1c8

Comment 17

[Saddam Hossain]

I have reproduced this Bug on Nightly 55.0a1 (2017-05-24)  on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 55.0a1

Build ID 	20170604030205
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]

Comment 18

[Hani Yacoub, Desktop QA]

Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.