Closed Bug 1367424 Opened 7 years ago Closed 7 years ago

[devtools-addon] Use DevToolsShim in addon-sdk

Categories

(DevTools :: General, enhancement, P3)

Product:
DevTools
Component:
General
Type:
enhancement

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(2 files)

Bug 1367424 - add shims for addon sdk to DevToolsShim;
59 bytes, text/x-review-board-request
ochameau
: review+
Details
Bug 1367424 - use DevTools shim in addon SDK;
59 bytes, text/x-review-board-request
rpl
: review+
Details 
Now that Bug 1356244, we should use the devtools shim to remove dependencies from the addonsdk code on DevTools code.
Starting some review requests here. 

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7ce7cd047083dcfa9d393a28b1917e9a487ea7e

There are still a few soft references to devtools in addon-sdk code:
- addon-sdk/source/lib/dev/theme.js references both the chrome paths for light-theme.css and dark-theme.css
- addon-sdk/source/lib/sdk/addon/bootstrap.js creates a loader that maps devtools/ to resource://devtools/
- addon-sdk/source/lib/toolkit/require.js creates a loader that maps devtools/ to resource://devtools/

If any addon is relying on those features, devtools will have to be installed for them to work.

For the code that was actually ported to the DevToolsShim, there are two different categories
- addon-sdk/source/lib/dev/toolbox.js was ported to APIs that will "hold" the calls until devtools are available (registerTheme, Tool etc)
- the other classes use wrappers provided by the DevToolsShim to avoid depending on devtools classes, but they will throw if devtools are not installed

Let me know if you think this is an issue. The plan is still to go for a hacks post in the coming weeks to give a heads up to extension developers before 56 hits release.
Attachment #8872386 - Flags: review?(amckay) → review?(lgreco)
Comment on attachment 8872385 [details]
Bug 1367424 - add shims for addon sdk to DevToolsShim;

https://reviewboard.mozilla.org/r/143886/#review148244

Thanks, looks good.
It is great having an explicit list of what is being used in addonSdkMethods!
Attachment #8872385 - Flags: review?(poirot.alex) → review+
Comment on attachment 8872386 [details]
Bug 1367424 - use DevTools shim in addon SDK;

https://reviewboard.mozilla.org/r/143888/#review148758

Thanks Julian, looks good to me.
Attachment #8872386 - Flags: review?(lgreco) → review+
Comment on attachment 8872386 [details]
Bug 1367424 - use DevTools shim in addon SDK;

Alex, this patch needs to be reviewed by an addon sdk peer, can you take a look?
Attachment #8872386 - Flags: review?(poirot.alex)
Comment on attachment 8872386 [details]
Bug 1367424 - use DevTools shim in addon SDK;

Forwarding to Matteo.
Attachment #8872386 - Flags: review?(poirot.alex) → review?(zer0)
Comment on attachment 8872386 [details]
Bug 1367424 - use DevTools shim in addon SDK;

Looks good to me!
Attachment #8872386 - Flags: review?(zer0) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ecdc6d29e1d
add shims for addon sdk to DevToolsShim;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/6f17a72e69cc
use DevTools shim in addon SDK;r=rpl
Backed out for failing jetpack's test-dev-panel.js.test Panel API and more:

https://hg.mozilla.org/integration/autoland/rev/1330312e91c96fea39eb4881672c5f9a7776bef1
https://hg.mozilla.org/integration/autoland/rev/3b60060e152977255d780db5d4504a80075107cd

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6f17a72e69cc9ccab071091347f6bb5cf7a57bab&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=104846139&repo=autoland

[task 2017-06-06T10:49:02.565740Z] 10:49:02     INFO -  TEST-START | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API
[task 2017-06-06T10:49:02.569724Z] 10:49:02     INFO -  TEST-PASS | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API | panel is defined
[task 2017-06-06T10:49:02.579539Z] 10:49:02     INFO -  TEST-PASS | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API | tool is defined
[task 2017-06-06T10:49:02.589153Z] 10:49:02     INFO -  *************************
[task 2017-06-06T10:49:02.590991Z] 10:49:02     INFO -  A coding exception was thrown and uncaught in a Task.
[task 2017-06-06T10:49:02.592828Z] 10:49:02     INFO -  Full message: TypeError: this._toolboxes is undefined
[task 2017-06-06T10:49:02.595028Z] 10:49:02     INFO -  Full stack: DevTools.prototype.showToolbox<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/devtools.js:445:9
[task 2017-06-06T10:49:02.596560Z] 10:49:02     INFO -  _run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
[task 2017-06-06T10:49:02.598339Z] 10:49:02     INFO -  TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
[task 2017-06-06T10:49:02.599975Z] 10:49:02     INFO -  asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
[task 2017-06-06T10:49:02.603097Z] 10:49:02     INFO -  this.DevToolsShim[method]@chrome://devtools-shim/content/DevToolsShim.jsm:223:12
[task 2017-06-06T10:49:02.605526Z] 10:49:02     INFO -  openToolbox@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/dev/utils.js:25:10
[task 2017-06-06T10:49:02.607996Z] 10:49:02     INFO -  exports["test Panel API"]<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jetpack-package-tests/jetpack-package/addon-sdk/source/test/test-dev-panel.js:74:23
[task 2017-06-06T10:49:02.610559Z] 10:49:02     INFO -  test/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jetpack-package-tests/jetpack-package/addon-sdk/source/test/test-dev-panel.js:42:12
[task 2017-06-06T10:49:02.612008Z] 10:49:02     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:321:42
[task 2017-06-06T10:49:02.613629Z] 10:49:02     INFO -  TaskImpl@resource://gre/modules/Task.jsm:279:3
[task 2017-06-06T10:49:02.614934Z] 10:49:02     INFO -  asyncFunction@resource://gre/modules/Task.jsm:254:14
[task 2017-06-06T10:49:02.616486Z] 10:49:02     INFO -  Task_spawn@resource://gre/modules/Task.jsm:168:12
[task 2017-06-06T10:49:02.618028Z] 10:49:02     INFO -  @resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test.js:54:13
[task 2017-06-06T10:49:02.619532Z] 10:49:02     INFO -  start@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:575:7
[task 2017-06-06T10:49:02.620898Z] 10:49:02     INFO -  runNextTest/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:537:11
[task 2017-06-06T10:49:02.622458Z] 10:49:02     INFO -  promise callback*runNextTest@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:531:14
[task 2017-06-06T10:49:02.623998Z] 10:49:02     INFO -  startMany@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:545:12
[task 2017-06-06T10:49:02.625491Z] 10:49:02     INFO -  findAndRunTests@chrome://mochikit/content/jetpack-package-harness.js:67:7
[task 2017-06-06T10:49:02.626806Z] 10:49:02     INFO -  checkForEnd@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:406:5
[task 2017-06-06T10:49:02.628299Z] 10:49:02     INFO -  nextIteration@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:397:5
[task 2017-06-06T10:49:02.630167Z] 10:49:02     INFO -  runTests@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:618:5
[task 2017-06-06T10:49:02.631713Z] 10:49:02     INFO -  testModule/<@chrome://mochikit/content/jetpack-package-harness.js:76:5
[task 2017-06-06T10:49:02.633414Z] 10:49:02     INFO -  testModule@chrome://mochikit/content/jetpack-package-harness.js:25:10
[task 2017-06-06T10:49:02.634740Z] 10:49:02     INFO -  testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.636465Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.638010Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.639521Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.640802Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.642447Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.643740Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.645280Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.646556Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.648728Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.650631Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.652210Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.653599Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.655239Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.656836Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.658487Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.660942Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.661067Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.661214Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.662397Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.663619Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.665312Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.666780Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.666919Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.668427Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.669557Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.671566Z] 10:49:02     INFO -  promise callback*testInit/<@chrome://mochikit/content/jetpack-package-harness.js:207:7
[task 2017-06-06T10:49:02.672649Z] 10:49:02     INFO -  parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
[task 2017-06-06T10:49:02.673869Z] 10:49:02     INFO -  getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
[task 2017-06-06T10:49:02.675039Z] 10:49:02     INFO -  EventHandlerNonNull*getTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
[task 2017-06-06T10:49:02.676147Z] 10:49:02     INFO -  getTestList@chrome://mochikit/content/chrome-harness.js:260:3
[task 2017-06-06T10:49:02.677260Z] 10:49:02     INFO -  testInit@chrome://mochikit/content/jetpack-package-harness.js:120:3
[task 2017-06-06T10:49:02.678345Z] 10:49:02     INFO -  setTimeout handler*@chrome://mochikit/content/jetpack-package-harness.js:21:1
[task 2017-06-06T10:49:02.679468Z] 10:49:02     INFO -  *************************
[task 2017-06-06T10:49:02.680547Z] 10:49:02     INFO -  *************************
[task 2017-06-06T10:49:02.681763Z] 10:49:02     INFO -  A coding exception was thrown and uncaught in a Task.
[task 2017-06-06T10:49:02.682937Z] 10:49:02     INFO -  Full message: TypeError: this._toolboxes is undefined
[task 2017-06-06T10:49:02.684034Z] 10:49:02     INFO -  Full stack: DevTools.prototype.showToolbox<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/framework/devtools.js:445:9
[task 2017-06-06T10:49:02.685128Z] 10:49:02     INFO -  _run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
[task 2017-06-06T10:49:02.686193Z] 10:49:02     INFO -  TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
[task 2017-06-06T10:49:02.687299Z] 10:49:02     INFO -  asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
[task 2017-06-06T10:49:02.688427Z] 10:49:02     INFO -  this.DevToolsShim[method]@chrome://devtools-shim/content/DevToolsShim.jsm:223:12
[task 2017-06-06T10:49:02.689599Z] 10:49:02     INFO -  openToolbox@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/dev/utils.js:25:10
[task 2017-06-06T10:49:02.690682Z] 10:49:02     INFO -  exports["test Panel API"]<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jetpack-package-tests/jetpack-package/addon-sdk/source/test/test-dev-panel.js:74:23
[task 2017-06-06T10:49:02.692093Z] 10:49:02     INFO -  test/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://jetpack-package-tests/jetpack-package/addon-sdk/source/test/test-dev-panel.js:42:12
[task 2017-06-06T10:49:02.693207Z] 10:49:02     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:321:42
[task 2017-06-06T10:49:02.694471Z] 10:49:02     INFO -  TaskImpl@resource://gre/modules/Task.jsm:279:3
[task 2017-06-06T10:49:02.695576Z] 10:49:02     INFO -  asyncFunction@resource://gre/modules/Task.jsm:254:14
[task 2017-06-06T10:49:02.696699Z] 10:49:02     INFO -  Task_spawn@resource://gre/modules/Task.jsm:168:12
[task 2017-06-06T10:49:02.697748Z] 10:49:02     INFO -  @resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test.js:54:13
[task 2017-06-06T10:49:02.699126Z] 10:49:02     INFO -  start@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:575:7
[task 2017-06-06T10:49:02.700281Z] 10:49:02     INFO -  runNextTest/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:537:11
[task 2017-06-06T10:49:02.701389Z] 10:49:02     INFO -  promise callback*runNextTest@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:531:14
[task 2017-06-06T10:49:02.702472Z] 10:49:02     INFO -  startMany@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/deprecated/unit-test.js:545:12
[task 2017-06-06T10:49:02.703674Z] 10:49:02     INFO -  findAndRunTests@chrome://mochikit/content/jetpack-package-harness.js:67:7
[task 2017-06-06T10:49:02.704729Z] 10:49:02     INFO -  checkForEnd@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:406:5
[task 2017-06-06T10:49:02.705859Z] 10:49:02     INFO -  nextIteration@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:397:5
[task 2017-06-06T10:49:02.706964Z] 10:49:02     INFO -  runTests@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/test/harness.js:618:5
[task 2017-06-06T10:49:02.707997Z] 10:49:02     INFO -  testModule/<@chrome://mochikit/content/jetpack-package-harness.js:76:5
[task 2017-06-06T10:49:02.709129Z] 10:49:02     INFO -  testModule@chrome://mochikit/content/jetpack-package-harness.js:25:10
[task 2017-06-06T10:49:02.710211Z] 10:49:02     INFO -  testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.711319Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.712511Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.713699Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.715011Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.716803Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.718562Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.719686Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.720853Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.721964Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.723014Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.724245Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.725336Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.726414Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.727473Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.728575Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.729706Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.731539Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.732776Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.733899Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.734961Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.736021Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.737640Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.737784Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.739428Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.740484Z] 10:49:02     INFO -  promise callback*testNextModule@chrome://mochikit/content/jetpack-package-harness.js:236:11
[task 2017-06-06T10:49:02.741662Z] 10:49:02     INFO -  promise callback*testInit/<@chrome://mochikit/content/jetpack-package-harness.js:207:7
[task 2017-06-06T10:49:02.742745Z] 10:49:02     INFO -  parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
[task 2017-06-06T10:49:02.744369Z] 10:49:02     INFO -  getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
[task 2017-06-06T10:49:02.745652Z] 10:49:02     INFO -  EventHandlerNonNull*getTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
[task 2017-06-06T10:49:02.745781Z] 10:49:02     INFO -  getTestList@chrome://mochikit/content/chrome-harness.js:260:3
[task 2017-06-06T10:49:02.747483Z] 10:49:02     INFO -  testInit@chrome://mochikit/content/jetpack-package-harness.js:120:3
[task 2017-06-06T10:49:02.748555Z] 10:49:02     INFO -  setTimeout handler*@chrome://mochikit/content/jetpack-package-harness.js:21:1
[task 2017-06-06T10:49:02.749639Z] 10:49:02     INFO -  *************************
[task 2017-06-06T10:49:02.751256Z] 10:49:02  WARNING -  TEST-UNEXPECTED-FAIL | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API | this._toolboxes is undefined
[task 2017-06-06T10:49:02.752692Z] 10:49:02     INFO -  TEST-INFO | Traceback (most recent call last):
[task 2017-06-06T10:49:02.753807Z] 10:49:02     INFO -    File "resource://gre/modules/Promise-backend.js", line 806, in walkerLoop
[task 2017-06-06T10:49:02.754944Z] 10:49:02     INFO -      this.handlers.shift().process();
[task 2017-06-06T10:49:02.756036Z] 10:49:02     INFO -    File "resource://gre/modules/Promise-backend.js", line 925, in process
[task 2017-06-06T10:49:02.757064Z] 10:49:02     INFO -      nextValue = this.onReject.call(undefined, nextValue);
[task 2017-06-06T10:49:02.758137Z] 10:49:02     INFO -    File "resource://gre/modules/commonjs/sdk/test/assert.js", line 88, in fail
[task 2017-06-06T10:49:02.759209Z] 10:49:02     INFO -      this._log.fail(message);
[task 2017-06-06T10:49:02.760348Z] 10:49:02     INFO -    File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 104, in fail
[task 2017-06-06T10:49:02.761469Z] 10:49:02     INFO -      this.console.testMessage(false, false, this.test.name, message);
[task 2017-06-06T10:49:02.762533Z] 10:49:02     INFO -    File "resource://gre/modules/commonjs/sdk/test/harness.js", line 541, in testMessage
[task 2017-06-06T10:49:02.763611Z] 10:49:02     INFO -      this.trace();
[task 2017-06-06T10:49:02.764757Z] 10:49:02     INFO -  TEST-PASS | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API | This test is done.
[task 2017-06-06T10:49:02.766407Z] 10:49:02     INFO -  TEST-PASS | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API | There was a clean UI.
[task 2017-06-06T10:49:02.767494Z] 10:49:02     INFO -  TEST-END | jetpack-package/addon-sdk/source/test/test-dev-panel.js.test Panel API
Flags: needinfo?(jdescottes)
Also fails toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html on Android:
https://treeherder.mozilla.org/logviewer.html#?job_id=104844809&repo=autoland
I made a small modification after submitting to try which created a regression. 
New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81d29c726442bc9469a59e4e4b0b4eb2a8581d4d
Flags: needinfo?(jdescottes)
There are frequent failures on both:
- browser/base/content/test/general/browser_plainTextLinks.js
- browser/base/content/test/plugins/browser_CTP_crashreporting.js

But both tests are currently investigated for a spike in their intermittent failures so I don't think this is related.

I will wait until after merge day to land this anyway. No reason to rush it into 55.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f972a227ac15
add shims for addon sdk to DevToolsShim;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/638eb8e2b170
use DevTools shim in addon SDK;r=rpl
Backed out for failing test_chrome_ext_hybrid_addons.html on Android (also occurred before last backout, see comment 14):

https://hg.mozilla.org/integration/autoland/rev/6f6615b9bed5a7587959f99dbf6f5c6af9beec8e
https://hg.mozilla.org/integration/autoland/rev/0ec68500aa1ae6fd46e94e1d2f06dbf472277ca2

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=638eb8e2b1700d088ff5bc121c8c44953e792322&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=106355428&repo=autoland

[task 2017-06-12T15:15:22.673523Z] 15:15:22     INFO -  60 INFO TEST-START | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html
[task 2017-06-12T15:20:23.264915Z] 15:20:23     INFO -  Buffered messages logged at 15:15:19
[task 2017-06-12T15:20:23.265729Z] 15:20:23     INFO -  61 INFO SpawnTask.js | Entering test test_sdk_hybrid_addon_with_jpm_module_loader
[task 2017-06-12T15:20:23.265793Z] 15:20:23     INFO -  62 INFO Extension loaded
[task 2017-06-12T15:20:23.265835Z] 15:20:23     INFO -  Buffered messages finished
[task 2017-06-12T15:20:23.266023Z] 15:20:23     INFO -  63 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html | Test timed out.
[task 2017-06-12T15:20:23.267465Z] 15:20:23     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2017-06-12T15:20:23.267513Z] 15:20:23     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
[task 2017-06-12T15:20:23.267562Z] 15:20:23     INFO -  64 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html | Extension left running at test shutdown
[task 2017-06-12T15:20:23.267600Z] 15:20:23     INFO -  ExtensionTestUtils.loadExtension/<@chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:109:7
[task 2017-06-12T15:20:23.267633Z] 15:20:23     INFO -  executeCleanupFunction@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1224:19
[task 2017-06-12T15:20:23.267665Z] 15:20:23     INFO -  SimpleTest.finish@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1237:5
[task 2017-06-12T15:20:23.267694Z] 15:20:23     INFO -  killTest@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:130:7
[task 2017-06-12T15:20:23.267726Z] 15:20:23     INFO -  delayedKillTest@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:157:47
[task 2017-06-12T15:20:55.380549Z] 15:20:55     INFO -  65 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html | Test timed out.
[task 2017-06-12T15:20:55.380677Z] 15:20:55     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2017-06-12T15:20:55.381837Z] 15:20:55     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
[task 2017-06-12T15:20:55.381908Z] 15:20:55     INFO -  66 ERROR [SimpleTest.finish()] this test already called finish!
[task 2017-06-12T15:20:55.381999Z] 15:20:55     INFO -  67 INFO TEST-OK | toolkit/components/extensions/test/mochitest/test_chrome_ext_hybrid_addons.html | took 332231ms
Flags: needinfo?(jdescottes)
I missed the toolkit failure on Android, sorry :(

I think this is probably linked to a devtools lazy import from addons/runner.js that ceased to be lazy with my patch.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f500c7f04648a36651ab9af834cbf3e3532e19
Flags: needinfo?(jdescottes)
Got the platform syntax wrong. New try on all platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7f0a55c25fe9b47620239b15de6a2812bd248aa
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f32fc387484
add shims for addon sdk to DevToolsShim;r=ochameau
https://hg.mozilla.org/integration/autoland/rev/bcdf5c38ef7a
use DevTools shim in addon SDK;r=rpl
Blocks: 1367425
https://hg.mozilla.org/mozilla-central/rev/0f32fc387484
https://hg.mozilla.org/mozilla-central/rev/bcdf5c38ef7a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: