1367478 - Support ws and wss protocols on the webRequest API

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

WebExtensions addons may want to listen for webRequest related to websocket connections (which use the ws and wss as the protocol names), e.g. uBlock-Origin is one of these extensions:

- https://github.com/gorhill/uBlock/blob/ca32a693df510fb1018ecde2e8a2412f622aab3c/platform/chromium/vapi-background.js#L1099-L1119

Currently, when trying to add a webRequest listener using ws or wss urls in the event filters logs, the following errors are logged in the console:

- Invalid match pattern: 'ws://*/*'
- Invalid match pattern: 'wss://*/*'
- The webRequest.addListener filter doesn't overlap with host permissions

Comment 1

[Shane Caraveo (:mixedpuppy)]

Websockets work fine in webrequest, the urls show up under http/s.  We could change the url for addons listening on websockets, but I wonder where else that url could end up being an issue.

In any case this waits on bug 1368102

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1367478 support websocket ws/wss protocol in matchpattern,

Review commit: https://reviewboard.mozilla.org/r/146840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146840/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8875399 [details]
Bug 1367478 support websocket ws/wss protocol in matchpattern,

https://reviewboard.mozilla.org/r/146840/#review151538

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62e44a827308
support websocket ws/wss protocol in matchpattern, r=kmag

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62e44a827308