Closed
Bug 1382834
Opened 8 years ago
Closed 8 years ago
ws/wss protocol in webrequest is partially broken
Categories
(WebExtensions :: Request Handling, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla56
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
The handling in shouldRunListener is completely wrong, it is treating nsIURI as a string. The test misses it as well by using * rather than ws for the url match.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8889683 [details]
Bug 1382834 fix ws/wss protocol matching,
https://reviewboard.mozilla.org/r/160746/#review167014
Attachment #8889683 -
Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59e214139531
fix ws/wss protocol matching, r=kmag
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
|
||
Updated•8 years ago
|
Keywords: dev-doc-needed
|
|
||
Comment 5•8 years ago
|
||
Shane, I'm not sure what if any doc updates are needed for this, can you help me understand that?
Flags: needinfo?(mixedpuppy)
|
Assignee | |
Comment 6•8 years ago
|
||
(In reply to Will Bamberg [:wbamberg] from comment #5)
> Shane, I'm not sure what if any doc updates are needed for this, can you
> help me understand that?
Probably none.
Flags: needinfo?(mixedpuppy)
|
||
Updated•7 years ago
|
Product: Toolkit → WebExtensions
|
|
||
Updated•7 years ago
|
status-firefox56:
fixed → ---
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•