ws/wss protocol in webrequest is partially broken

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
WebExtensions: Request Handling
P1
normal
RESOLVED FIXED
a month ago
7 days ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

({dev-doc-needed})

49 Branch
mozilla56
dev-doc-needed
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
The handling in shouldRunListener is completely wrong, it is treating nsIURI as a string.  The test misses it as well by using * rather than ws for the url match.
(Assignee)

Updated

a month ago
Blocks: 1367478
Comment hidden (mozreview-request)

Comment 2

29 days ago
mozreview-review
Comment on attachment 8889683 [details]
Bug 1382834 fix ws/wss protocol matching,

https://reviewboard.mozilla.org/r/160746/#review167014
Attachment #8889683 - Flags: review?(kmaglione+bmo) → review+

Comment 3

28 days ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59e214139531
fix ws/wss protocol matching, r=kmag

Comment 4

27 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/59e214139531
Status: NEW → RESOLVED
Last Resolved: 27 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.