ws/wss protocol in webrequest is partially broken

RESOLVED FIXED in mozilla56

Status

P1
normal
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

49 Branch
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The handling in shouldRunListener is completely wrong, it is treating nsIURI as a string.  The test misses it as well by using * rather than ws for the url match.
(Assignee)

Updated

a year ago
Blocks: 1367478
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8889683 [details]
Bug 1382834 fix ws/wss protocol matching,

https://reviewboard.mozilla.org/r/160746/#review167014
Attachment #8889683 - Flags: review?(kmaglione+bmo) → review+

Comment 3

a year ago
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59e214139531
fix ws/wss protocol matching, r=kmag

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/59e214139531
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Keywords: dev-doc-needed
Depends on: 1398622
Shane, I'm not sure what if any doc updates are needed for this, can you help me understand that?
Flags: needinfo?(mixedpuppy)
(Assignee)

Comment 6

a year ago
(In reply to Will Bamberg [:wbamberg] from comment #5)
> Shane, I'm not sure what if any doc updates are needed for this, can you
> help me understand that?

Probably none.
Flags: needinfo?(mixedpuppy)

Updated

5 months ago
Product: Toolkit → WebExtensions
status-firefox56: fixed → ---
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.