Closed Bug 1382834 Opened 3 years ago Closed 3 years ago

ws/wss protocol in webrequest is partially broken

Categories

(WebExtensions :: Request Handling, defect, P1)

49 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla56

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

Attachments

(1 file)

The handling in shouldRunListener is completely wrong, it is treating nsIURI as a string.  The test misses it as well by using * rather than ws for the url match.
Blocks: 1367478
Comment on attachment 8889683 [details]
Bug 1382834 fix ws/wss protocol matching,

https://reviewboard.mozilla.org/r/160746/#review167014
Attachment #8889683 - Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59e214139531
fix ws/wss protocol matching, r=kmag
https://hg.mozilla.org/mozilla-central/rev/59e214139531
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1398622
Shane, I'm not sure what if any doc updates are needed for this, can you help me understand that?
Flags: needinfo?(mixedpuppy)
(In reply to Will Bamberg [:wbamberg] from comment #5)
> Shane, I'm not sure what if any doc updates are needed for this, can you
> help me understand that?

Probably none.
Flags: needinfo?(mixedpuppy)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.