1367631 - Round the dest rect of image layer to match the color layer behavior

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

There is a reftest failure[1] when turning on canvas background color. Because we round the bound of the color layer but we don't do rounding for image layer.

[1] layout/reftests/pixel-rounding/rounded-background-color-top-4.html

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Round the dest rect of the image layer

The patch can fix the reftest failures when using canvas background color layer. I checked the Non-QR try[1] and it looks like the patch doesn't cause new failures. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbd891d1bd99d8c3b504d446739e40b2389cd377&selectedJob=101826673

Comment 2

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=854a8c4faae3255ad73632be569f794ff23fa56d&selectedJob=103257444

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd47ac3e215
Round the dest rect of the image layer to match the color layer behavior. r=mattwoodrow

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5dd47ac3e215