Round the dest rect of image layer to match the color layer behavior

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

Assignee

Description

2 years ago
There is a reftest failure[1] when turning on canvas background color. Because we round the bound of the color layer but we don't do rounding for image layer.

[1] layout/reftests/pixel-rounding/rounded-background-color-top-4.html
Assignee

Comment 1

2 years ago
The patch can fix the reftest failures when using canvas background color layer. I checked the Non-QR try[1] and it looks like the patch doesn't cause new failures. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbd891d1bd99d8c3b504d446739e40b2389cd377&selectedJob=101826673
Attachment #8871148 - Flags: review?(matt.woodrow)
Whiteboard: gfx-noted
Assignee

Updated

2 years ago
Assignee: nobody → ethlin
Assignee

Updated

2 years ago
Blocks: 1367987
Attachment #8871148 - Flags: review?(matt.woodrow) → review+

Comment 3

2 years ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd47ac3e215
Round the dest rect of the image layer to match the color layer behavior. r=mattwoodrow

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5dd47ac3e215
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.