1367668 - [Payment Request API] Fix the crash due to "Hit MOZ_CRASH(IPC message size is too large) " when doing constructor tests

Status: RESOLVED WORKSFORME

(Core :: DOM: Web Payments, enhancement)

Description

[Alphan Chen [:alchen]]

constructor tests: https://w3c-test.org/payment-request/payment-request-constructor.https.html

We will meet crash on two test cases.

1.
const newDetails = Object.assign({}, defaultDetails, {
  id: "".padStart(100000000, "\n test 123 \t \n "),
});

2.
const recursiveDictionary = {};
recursiveDictionary.foo = recursiveDictionary;

Comment 1

[Ben Tian (inactive)]

> 2.
> const recursiveDictionary = {};
> recursiveDictionary.foo = recursiveDictionary;

We may use CycleDetector for the case.
http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/js/src/json.cpp#299

Comment 2

[Ben Tian (inactive)]

(In reply to Alphan Chen [:alchen] from comment #0)
> 2.
> const recursiveDictionary = {};
> recursiveDictionary.foo = recursiveDictionary;

The latest Nightly passes the test "Rethrow any exceptions of JSON-serializing paymentMethod.data into a string"
https://w3c-test.org/payment-request/payment-request-constructor.https.html

Comment 3

[Ben Tian (inactive)]

(In reply to Alphan Chen [:alchen] from comment #0)
> constructor tests:
> https://w3c-test.org/payment-request/payment-request-constructor.https.html
> 
> We will meet crash on two test cases.
> 
> 1.
> const newDetails = Object.assign({}, defaultDetails, {
>   id: "".padStart(100000000, "\n test 123 \t \n "),
> });

The latest test has decreased the number and our implementation doesn't crash.
https://github.com/w3c/web-platform-tests/blob/master/payment-request/payment-request-constructor.https.html#L44

Comment 4

[Ben Tian (inactive)]

Resolve as WFM per comment 2 & 3. Feel free to reopen if the bug re-occurs.