audio controls disappear if there is a brief dynamic change to a small "width"

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Video/Audio Controls
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: dholbert, Assigned: ralin)

Tracking

(Blocks: 1 bug, {regression, testcase})

Trunk
mozilla56
regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox-esr52 unaffected, firefox53 wontfix, firefox54 wontfix, firefox55 fixed, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Created attachment 8871414 [details]
testcase 1

STR:
 1. Load attached testcase.

EXPECTED RESULTS:
Visible audio controls.

ACTUAL RESULTS:
Audio controls disappear after the JS tweak.


The testcase just sets the <audio> element to an extremely small width, and then undoes that change.  This brief visit to a small width seems to break the element permanently.

mozregression says this regressed as part of the video/audio controls rewrite in bug 1271765.
(Reporter)

Updated

5 months ago
status-firefox53: --- → affected
status-firefox54: --- → affected
status-firefox55: --- → affected
status-firefox-esr45: --- → unaffected
status-firefox-esr52: --- → unaffected
(Reporter)

Updated

5 months ago
Flags: needinfo?(ralin)
(Reporter)

Comment 1

5 months ago
(It's possible this bug & bug 1367846 are the same issue under the hood; not sure.)
See Also: → bug 1367846
(Assignee)

Comment 2

5 months ago
It's not exact the same issue as 1367846 and bug 1362146. The controls should recovery from the "hide" state to normal size once undo the size constraints. I'll deal with bug 1362146 first, and then this. Thanks :)
Flags: needinfo?(ralin)
(Assignee)

Updated

5 months ago
Depends on: 1362146
Too late to fix for 53, may be a bit late for 54 but if you get a fix and can verify it please request uplift.   Ray, want to assign this bug to yourself if you intend to work on it?
status-firefox53: affected → wontfix
Flags: needinfo?(ralin)
(Assignee)

Comment 4

5 months ago
I am thinking to fix those size adjusting issues at once, so no harm to take this as I've already on bug 1362146. Thank you Liz.
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Flags: needinfo?(ralin)
(Assignee)

Updated

5 months ago
Blocks: 1368639
(Assignee)

Updated

5 months ago
No longer depends on: 1362146
Too late for 54. Mark 54 won't fix.
status-firefox54: affected → wontfix
(Assignee)

Comment 6

4 months ago
Tested with 56.0a1 (2017-07-03) (64-bit) on Mac, and it looks like this issue has been fixed by Bug 1373537. It's good to have a reftest nonetheless.
Comment hidden (mozreview-request)

Comment 8

4 months ago
mozreview-review
Comment on attachment 8883204 [details]
Bug 1367875 - Add a reftest about brief dynamically chaning <audio> to a small width.

https://reviewboard.mozilla.org/r/154144/#review159624
Attachment #8883204 - Flags: review?(jaws) → review+
(Assignee)

Comment 9

4 months ago
Thanks for the review.

In order not to conflict with reftest.list, I'll land this after Bug 1367868.
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Keywords: checkin-needed

Comment 11

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a3c423b4ab94
Add a reftest about brief dynamically chaning <audio> to a small width. r=jaws
Keywords: checkin-needed

Comment 12

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3c423b4ab94
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Comment 13

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/4a2dd6e45c4c
status-firefox55: affected → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.