1367875 - audio controls disappear if there is a brief dynamic change to a small "width"

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:
 1. Load attached testcase.

EXPECTED RESULTS:
Visible audio controls.

ACTUAL RESULTS:
Audio controls disappear after the JS tweak.


The testcase just sets the <audio> element to an extremely small width, and then undoes that change.  This brief visit to a small width seems to break the element permanently.

mozregression says this regressed as part of the video/audio controls rewrite in bug 1271765.

Comment 1

[Daniel Holbert [:dholbert]]

(It's possible this bug & bug 1367846 are the same issue under the hood; not sure.)

Comment 2

[Ray Lin[:ralin]]

It's not exact the same issue as 1367846 and bug 1362146. The controls should recovery from the "hide" state to normal size once undo the size constraints. I'll deal with bug 1362146 first, and then this. Thanks :)

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late to fix for 53, may be a bit late for 54 but if you get a fix and can verify it please request uplift.   Ray, want to assign this bug to yourself if you intend to work on it?

Comment 4

[Ray Lin[:ralin]]

I am thinking to fix those size adjusting issues at once, so no harm to take this as I've already on bug 1362146. Thank you Liz.

Comment 5

[Gerry Chang [:gchang]]

Too late for 54. Mark 54 won't fix.

Comment 6

[Ray Lin[:ralin]]

Tested with 56.0a1 (2017-07-03) (64-bit) on Mac, and it looks like this issue has been fixed by Bug 1373537. It's good to have a reftest nonetheless.

Comment 7

[Ray Lin[:ralin]]

Attachment: Bug 1367875 - Add a reftest about brief dynamically chaning <audio> to a small width.

Review commit: https://reviewboard.mozilla.org/r/154144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154144/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8883204 [details]
Bug 1367875 - Add a reftest about brief dynamically chaning <audio> to a small width.

https://reviewboard.mozilla.org/r/154144/#review159624

Comment 9

[Ray Lin[:ralin]]

Thanks for the review.

In order not to conflict with reftest.list, I'll land this after Bug 1367868.

Comment 10

[Ray Lin[:ralin]]

Comment on attachment 8883204 [details]
Bug 1367875 - Add a reftest about brief dynamically chaning <audio> to a small width.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154144/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c423b4ab94
Add a reftest about brief dynamically chaning <audio> to a small width. r=jaws

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a3c423b4ab94

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a2dd6e45c4c