Closed
Bug 1367875
Opened 7 years ago
Closed 7 years ago
audio controls disappear if there is a brief dynamic change to a small "width"
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox-esr52 | --- | unaffected |
firefox53 | --- | wontfix |
firefox54 | --- | wontfix |
firefox55 | --- | fixed |
firefox56 | --- | fixed |
People
(Reporter: dholbert, Assigned: ralin)
References
(Blocks 1 open bug)
Details
(Keywords: regression, testcase)
Attachments
(2 files)
STR: 1. Load attached testcase. EXPECTED RESULTS: Visible audio controls. ACTUAL RESULTS: Audio controls disappear after the JS tweak. The testcase just sets the <audio> element to an extremely small width, and then undoes that change. This brief visit to a small width seems to break the element permanently. mozregression says this regressed as part of the video/audio controls rewrite in bug 1271765.
Reporter | ||
Updated•7 years ago
|
status-firefox53:
--- → affected
status-firefox54:
--- → affected
status-firefox55:
--- → affected
status-firefox-esr45:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(ralin)
Reporter | ||
Comment 1•7 years ago
|
||
(It's possible this bug & bug 1367846 are the same issue under the hood; not sure.)
See Also: → 1367846
Assignee | ||
Comment 2•7 years ago
|
||
It's not exact the same issue as 1367846 and bug 1362146. The controls should recovery from the "hide" state to normal size once undo the size constraints. I'll deal with bug 1362146 first, and then this. Thanks :)
Flags: needinfo?(ralin)
Comment 3•7 years ago
|
||
Too late to fix for 53, may be a bit late for 54 but if you get a fix and can verify it please request uplift. Ray, want to assign this bug to yourself if you intend to work on it?
Flags: needinfo?(ralin)
Assignee | ||
Comment 4•7 years ago
|
||
I am thinking to fix those size adjusting issues at once, so no harm to take this as I've already on bug 1362146. Thank you Liz.
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Flags: needinfo?(ralin)
Assignee | ||
Comment 6•7 years ago
|
||
Tested with 56.0a1 (2017-07-03) (64-bit) on Mac, and it looks like this issue has been fixed by Bug 1373537. It's good to have a reftest nonetheless.
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8883204 [details] Bug 1367875 - Add a reftest about brief dynamically chaning <audio> to a small width. https://reviewboard.mozilla.org/r/154144/#review159624
Attachment #8883204 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 9•7 years ago
|
||
Thanks for the review. In order not to conflict with reftest.list, I'll land this after Bug 1367868.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a3c423b4ab94 Add a reftest about brief dynamically chaning <audio> to a small width. r=jaws
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3c423b4ab94
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/4a2dd6e45c4c
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•