1367909 - Sidebar switcher background hover should be the width of the item (not the full width of the container)

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Aaron Benson]

Currently, the hover effect for the sidebar switcher spans the whole width of the container (which looks odd). Let's change it so the background color is only as wide as the icon+label+down arrow.

See the updated spec, here (very bottom): https://mozilla.invisionapp.com/share/TPBBJYIZ3#/231191185_Explainer_-_Sidebar

Comment 1

[Aaron Benson]

Updated spec link: https://mozilla.invisionapp.com/share/KZBRDI1EU#/234257205_Action_Menu_-_Send_To_Device

Comment 2

[Aaron Benson]

... and one more time for the right spec link: https://mozilla.invisionapp.com/share/ENBBK0F9U#/235741003_Explainer_-_Sidebar

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1367909 and bug 1368973 - fix sidebar header button cropping and hover state,

Review commit: https://reviewboard.mozilla.org/r/147128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147128/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8875695 [details]
Bug 1367909 and bug 1368973 - fix sidebar header button cropping and hover state,

https://reviewboard.mozilla.org/r/147128/#review151324

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e36088242fac
and bug 1368973 - fix sidebar header button cropping and hover state, r=bgrins

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e36088242fac

Comment 8

[:Gijs (he/him)]

When verifying, please also verify bug 1368973 is fixed by this patch.

Comment 10

[u554753]

Verified on Windows, Mac, and Ubuntu.