1367980 - Don't release decoder immediately even we've finished decoding

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Alastor Wu [:alwu]]

On Android,mthe life cycle of graphic buffer is equal to Android's codec, and it would be released immediately if we shutdown the decoder.

Since the buffer has been release, the memory we access is totally meaningless. The result is we would render the black image on the screen.

STR.
1. go to https://people-mozilla.org/~alwu/mochitest/wemb.html

Expected.
2. The video is playing smoothly

Actual.
2. The video is flashing

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1367980 - don't release decoder in complete state on Fennec.

On Android, the life cycle of graphic buffer is equal to Android's codec, and
it would be released immediately if we shutdown the decoder.

Since the buffer has been release, the memory we access is totally meaningless.
The result is we would render the black image on the screen.

In addition, I suspect this issue might be one of the root cause which results
in lots of timeout for media mochitest, so I would like to land this patch first,
and then do the follow-up in bug1367983.

Review commit: https://reviewboard.mozilla.org/r/143132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143132/

Comment 2

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c957d558005003d384c6e6f487683d2b5b12f35

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8871630 [details]
Bug 1367980 - don't release decoder in complete state on Fennec.

https://reviewboard.mozilla.org/r/143132/#review147380

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04c6a723dddc
don't release decoder in complete state on Fennec. r=jwwang

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/04c6a723dddc