Don't release decoder immediately even we've finished decoding

RESOLVED FIXED in Firefox 55

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
On Android,mthe life cycle of graphic buffer is equal to Android's codec, and it would be released immediately if we shutdown the decoder.

Since the buffer has been release, the memory we access is totally meaningless. The result is we would render the black image on the screen.

STR.
1. go to https://people-mozilla.org/~alwu/mochitest/wemb.html

Expected.
2. The video is playing smoothly

Actual.
2. The video is flashing
Assignee

Updated

2 years ago
Blocks: 1367983
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8871630 - Flags: review?(jwwang)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8871630 [details]
Bug 1367980 - don't release decoder in complete state on Fennec.

https://reviewboard.mozilla.org/r/143132/#review147380
Attachment #8871630 - Flags: review?(jwwang) → review+

Comment 4

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04c6a723dddc
don't release decoder in complete state on Fennec. r=jwwang

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04c6a723dddc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Assignee

Updated

2 years ago
Blocks: 1375389
You need to log in before you can comment on or make changes to this bug.