1368016 - Compact themes should stop messing with the back and forward buttons

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Since the compact (and touch) modes will be decoupled from "compact" themes, these themes should stop adjusting the back and forward buttons to be compact.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1368016 - [photon] Remove back and forward button adjustments from compact themes.

Since the compact (and touch) modes will be decoupled from "compact" themes, these themes should stop adjusting the back and forward buttons to be compact.

Review commit: https://reviewboard.mozilla.org/r/143188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143188/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8871681 [details]
Bug 1368016 - [photon] Remove back and forward button adjustments from compact themes.

https://reviewboard.mozilla.org/r/143188/#review146934

Thanks!

This patch has the obvious side effect of making the compact themes not-so-compact anymore, but based on comment 0 and the ongoing compact/touch mode work, I assume this is intentional.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #2)
> Comment on attachment 8871681 [details]
> Bug 1368016 - [photon] Remove back and forward button adjustments from
> compact themes.
> 
> https://reviewboard.mozilla.org/r/143188/#review146934
> 
> Thanks!
> 
> This patch has the obvious side effect of making the compact themes
> not-so-compact anymore, but based on comment 0 and the ongoing compact/touch
> mode work, I assume this is intentional.

Yep.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de53d306319
[photon] Remove back and forward button adjustments from compact themes. r=nhnt11

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3de53d306319