Closed Bug 1368016 Opened 4 years ago Closed 4 years ago

Compact themes should stop messing with the back and forward buttons

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [photon-visual][p1][57])

Attachments

(1 file)

Bug 1368016 - [photon] Remove back and forward button adjustments from compact themes.
59 bytes, text/x-review-board-request
nhnt11
: review+
Details 
Since the compact (and touch) modes will be decoupled from "compact" themes, these themes should stop adjusting the back and forward buttons to be compact.
Attachment #8871681 - Flags: review?(jhofmann)
Attachment #8871681 - Flags: review?(nhnt11)
Comment on attachment 8871681 [details]
Bug 1368016 - [photon] Remove back and forward button adjustments from compact themes.

https://reviewboard.mozilla.org/r/143188/#review146934

Thanks!

This patch has the obvious side effect of making the compact themes not-so-compact anymore, but based on comment 0 and the ongoing compact/touch mode work, I assume this is intentional.
Attachment #8871681 - Flags: review?(nhnt11) → review+
(In reply to Nihanth Subramanya [:nhnt11] from comment #2)
> Comment on attachment 8871681 [details]
> Bug 1368016 - [photon] Remove back and forward button adjustments from
> compact themes.
> 
> https://reviewboard.mozilla.org/r/143188/#review146934
> 
> Thanks!
> 
> This patch has the obvious side effect of making the compact themes
> not-so-compact anymore, but based on comment 0 and the ongoing compact/touch
> mode work, I assume this is intentional.

Yep.
Attachment #8871681 - Flags: review?(jhofmann)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3de53d306319
[photon] Remove back and forward button adjustments from compact themes. r=nhnt11
Iteration: --- → 55.6 - May 29
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
https://hg.mozilla.org/mozilla-central/rev/3de53d306319
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.