Closed Bug 1350210 Opened 7 years ago Closed 7 years ago

Add setting for Compact and Touch theme modes (a.k.a. "Density" control)

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Status
firefox56 --- verified

People

(Reporter: nhnt11, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-visual][p1][57])

Attachments

(3 files)

Stephen, I interpret this to mean "add an item to about:preferences for choosing compact themes".

a) Is this right? If so,
b) Where do we want the setting to appear? I'd guess General.
c) What UI mechanism do we want to supply to let the user choose between light/dark?
d) Do we keep the items in the "Appearance" section in about:addons?
Flags: needinfo?(shorlander)
I'm not really sure how this is different from bug 1314091...
(In reply to Dão Gottwald [::dao] from comment #1)
> I'm not really sure how this is different from bug 1314091...

I believe UX's current plan is for there to be settings that control spacing similar to what the custom 'compact' themes do, that also have a 'touch' setting (ie more spacing than normal). This would likely imply removing compact themes as they currently exist.
Depends on: 1352358
Blocks: 1354332
Depends on: 1355442
Component: Preferences → Toolbars and Customization
Flags: needinfo?(shorlander)
OS: Unspecified → All
Hardware: Unspecified → All
Summary: Add Setting for Compact Themes → Add setting for Compact and Touch theme modes
Whiteboard: [photon] → [photon][57]
Priority: -- → P1
Whiteboard: [photon][57] → [photon-visual][57]
Blocks: 1355771
Flags: qe-verify+
Priority: P1 → P2
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][57] → [photon-visual][p1][57]
QA Contact: ovidiu.boca → brindusa.tot
Depends on: 1363023
Depends on: 1365912
Depends on: 1366346
Found a mockup showing at least where the switch would be:
https://mozilla.invisionapp.com/share/Y7BQQLJDC#/screens/229252092_Customize_-_Empty_Overflow

Not sure if this is up to date.
Depends on: 1366363
Depends on: 1366369
Blocks: 1367284
No longer blocks: 1367284
Summary: Add setting for Compact and Touch theme modes → Add setting for Compact and Touch theme modes (a.k.a. "Density" control)
Depends on: 1368016
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Iteration: --- → 55.7 - Jun 12
Priority: P2 → P1
Iteration: 55.7 - Jun 12 → 56.1 - Jun 26
Spec is here:

https://mozilla.invisionapp.com/share/WUBRB21NH#/screens/229252091_Customization

Aaron, I would require the three icons for compact, normal and tablet mode. Can you help me with that?

Thanks!
Flags: needinfo?(abenson)
I believe Stephen is working on these icons.
Flags: needinfo?(abenson) → needinfo?(shorlander)
Depends on: 1376115
Iteration: 56.1 - Jun 26 → 56.2 - Jul 10
I just pushed a new version, rebased and added a file I forgot to hg add.

Note that this doesn't have the icons yet. Shorlander is still working on those.

I'll attach another patch with tests soon.
Comment on attachment 8882036 [details]
Bug 1350210 - Part 1 - Add UI density settings to customize mode.

https://reviewboard.mozilla.org/r/153112/#review158544
Attachment #8882036 - Flags: review?(jaws) → review+
Comment on attachment 8882237 [details]
Bug 1350210 - Part 2 - Add a test for UI density settings in customize mode.

https://reviewboard.mozilla.org/r/153318/#review158546

::: commit-message-b9cf8:3
(Diff revision 1)
> +Bug 1350210 - Add a test for UI density settings in customize mode. r=jaws
> +
> +Lines beginning with 'HG:' are removed.

Please delete this line :)
Attachment #8882237 - Flags: review?(jaws) → review+
Comment on attachment 8882513 [details]
Bug 1350210 - Part 3 - Add uidensity icons and only show uidensity settings in Photon.

https://reviewboard.mozilla.org/r/153628/#review158734

LGTM. Please add the license header to the SVGs.
Attachment #8882513 - Flags: review?(nhnt11) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ca48df874f4a -d 0c16e7a1a10f: rebasing 404738:ca48df874f4a "Bug 1350210 - Part 1 - Add UI density settings to customize mode. r=jaws"
merging browser/base/content/browser.js
merging browser/components/customizableui/CustomizeMode.jsm
merging browser/locales/en-US/chrome/browser/browser.dtd
merging browser/themes/shared/customizableui/customizeMode.inc.css
warning: conflicts while merging browser/locales/en-US/chrome/browser/browser.dtd! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43d356910d30
Part 1 - Add UI density settings to customize mode. r=jaws
https://hg.mozilla.org/integration/autoland/rev/55be54e2fce3
Part 2 - Add a test for UI density settings in customize mode. r=jaws
https://hg.mozilla.org/integration/autoland/rev/7389f9de8f21
Part 3 - Add uidensity icons and only show uidensity settings in Photon. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/43d356910d30
https://hg.mozilla.org/mozilla-central/rev/55be54e2fce3
https://hg.mozilla.org/mozilla-central/rev/7389f9de8f21
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Passing by note: the .properties file has been created with Windows line endings (CRLF), while they usually have Unix line endings (LF).
Depends on: 1378215
Depends on: 1378503
I can see ui "Density" settings added to "Customize" in latest Nightly 56.0a1 in 64-bit Linux.

Build ID 	20170706130309
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170705]
Depends on: 1379122
Depends on: 1379123
I can see the feature implemented in latest Nightly 56.0a1 on Windows 10, 64-bit  

Build ID :   20170706060058
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170705]
As this bug is verified as fixed in both linux(comment 29) and windows(comment 30), I am marking this as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(shorlander)
Depends on: 1381872
Depends on: 1383031
Regressions: 1556726
You need to log in before you can comment on or make changes to this bug.