1368024 - Web Apps - Fall back to 'name' when 'short_name' is missing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Oana Horvath [:ohorvath - out of office]]

Devices:
-Huawei Honor 8 (Android 6.0);
-HTC Nexus 9 (Android 7.1.1);

Build: Nightly 55.0a1 (2017-05-24);

Steps to reproduce:
1. Install https://podle.audio/v7/ or paperplanes.world as PWA.
2. Check the PWA's title on the home screen. 

Expected result:
The title should be the one found in the manifest file. Both apps have names specified in the manifest.

Actual result:
Both apps have names specified in the manifest, but they are installed with the url instead of a name.

Notes:
Not reproducing on Chrome.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Information from IRC, root cause is: "we only use short_name then fall back to url, we should short_name || name || start_url ".

Comment 2

[Dale Harvey (:daleharvey)]

Will restart again when GeckoView pwa lands

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

I can reproduce this. Needs fixed. Wesly can you get an assignee?

Comment 4

[Wesly Huang (EPM)]

let's see if we can get this done in the 58 Nightly cycle.

If not all the PWA frontend work in 58 nightly, then need to prioritize it with Joe/Andreas.

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1368024 - Fall back to 'name' when 'short_name' is missing.

Review commit: https://reviewboard.mozilla.org/r/186704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186704/

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8915488 [details]
Bug 1368024 - Fall back to 'name' when 'short_name' is missing.

https://reviewboard.mozilla.org/r/186704/#review192216

Looks good cheers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c879c334aa29
Fall back to 'name' when 'short_name' is missing. r=daleharvey

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c879c334aa29

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Verified using the steps in Comment 0. The name is properly displayed now.