1.08 KB, text/plain
3.00 KB, text/plain
133.80 KB, image/jpeg
4.98 KB, text/plain
2.92 KB, text/plain
1.76 KB, patch
Jean-Francois Ducarroz: review+
Judson Valeski: approval+
|Details | Diff | Splinter Review|
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9+) Gecko/20020410 BuildID: 2002041011, Mozilla 1.0.0 branch build. I have sent myself a message with national characters in the subject line, requesting the MDN return receipt. When the message arrived, I let Mozilla to send back the receipt. As a receipt came, it was broken because some header info got between the subject lines (the subject was divided into two lines and the second line appeared after some headers added by server). I will try to add some testcase to make things clear. Reproducible: Always Steps to Reproduce: 1.Send e-mail with ISO 8859-2 characters in the subject line (to yourself), request a return receipt. Make this subject rather long (about 50 chars). 2.Allow to send the receipt when the message arrives. 3.Get the receipt and watch it's contents Actual Results: The contents starts with part of the subject (it's second line). The contents is displayed as a plain text message, not formatted in parts like return receipts. Expected Results: Get a regular return receipt. Of course the wrong display is caused by misinterpreting message headers, as the given attachments will show. I tested this with long subject with only ascii characters and it worked fine.
Created attachment 78673 [details] Message with national characters in the subject line The message I sent to myself. It contains some ISO 8859-2 characters in the subject line.
Created attachment 78674 [details] Return receipt with broken subject This is the return receipt I got after viewing the message. Note the empty line before the second subject line.
Jeff, will you take care of that problem?
Assignee: ducarroz → jt95070
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Marina, do you see the problem on windows?
Created attachment 79004 [details] A screen shot. I kind of can reproduce the problem with a Simplified Chinese mail. In my case, the long subject display is cut off, but the message source shows that there are multiple line of subject header there.
Created attachment 79011 [details] Mesg source of Return Receipt w/ISO 8859-2 characters Alex, are you still seeing this problem? I've set my char coding to ISO 8859-2 and even tried your exact same subj line. But My Return Receipt is all in one line. Tested 2002041011 commercial branch build.
QA contact to me.
QA Contact: gchan → ji
i see this problem on windows with a long subject line which is cut off.The beginning of the subject is on the subject line and then it is displayed in the message body as quoted printabale. In the source however we see it in the subject line.
Created attachment 79578 [details] [diff] [review] Patch ready for review and super-review Please review and super-review. It would be nice to have it fixed in nsbeta1 or RTM.
Please review this patch. From the layman's point of view (well, I am a programmer, but not a Mozilla programmer), it seems to be clear and rather narrow. Jeff, maybe if you provided a diff it would help the reviewers? This bug may be very visible when using receipts in international environment.
Adding nsbeta1 based on Jeff's comments.
Adam, the patch is attached to the bug on 4/16 and waiting for review.
Jeff, the last patch doesn't seem to be a diff!
Created attachment 80402 [details] [diff] [review] proposed fix here's the diff, created by saving Jeff's attachment and diff'ing it.
Created attachment 80404 [details] [diff] [review] whoops, diffed the wrong way whoops, diff had the wrong sense - I think this is what Jeff intended.
Comment on attachment 80404 [details] [diff] [review] whoops, diffed the wrong way one problem with this patch is that it doesn't use the localized "[no subject]" string - I'll see how hard it would be to fix that.
Comment on attachment 80404 [details] [diff] [review] whoops, diffed the wrong way R=ducarroz. Would be nice if instead of hardcoding "[no subject]" you could reuse the defaultSubject string defined in composeMsg.properties but for that you will propably need to define an id for it.
yes, see my comment above. I tried getting the string from the string bundle, but I didn't what routine to call to convert the unicode string result to a mime header.
Comment on attachment 80404 [details] [diff] [review] whoops, diffed the wrong way sr=bienvenu
Attachment #80404 - Flags: superreview+
Will this patch be checked into the 1.0 branch?
No longer blocks: 139694
If someone tells me I can/should...
impact summery: impact language users- 339M potential users or 59.8% of the total internet users who are not use English as their native language. Visibility: The beta user themself won't see the problem. But the person who send them mail and request for receipt will see the problem. Severity: this will break one major enterprise feature (MDN) usage outside English speaking users. The essential information (which message got received by the receiver) will be lost. We should consider this as data lost. work around: None putterman: can you put a [adtx] and or nsbeta1+ on the status whiteboard ?
Please check this into the trunk so we can get some testing on it.
Keywords: nsbeta1 → adt1.0.0, nsbeta1+
Whiteboard: [adt2 rtm]
David has checked in the fix to the trunk. Thanks David.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Whiteboard: [adt2 rtm] → [adt2 rtm] [fix to trunk]
adding adt1.0.0+. Please get drivers approval and then check into the 1.0 branch.
Keywords: adt1.0.0 → adt1.0.0+
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1 milestone. Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+
please checkin to the 1.0.1 branch ASAP. once there please remove the mozilla1.0.1+ keyword and add the fixed1.0.1 keyword.
David or Navin, can you check this in for Jeff?
reopening so I can reassign.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Navin, can you check this onto the 1.0.1 branch?
Assignee: jt95070 → naving
Status: REOPENED → NEW
marking fixed again.
Status: NEW → RESOLVED
Last Resolved: 16 years ago → 16 years ago
Resolution: --- → FIXED
Is proposed fix the right patch here? "whoops, diffed the wrong way" has r/sr/a and it seems to be already there.
I guess I already checked it into the branch.
Keywords: mozilla1.0.1+ → fixed1.0.1
QA contact to marina. Thanks.
verified with 2002-08-01-1.0 build, the return receipt displays correctly on RedHat7.2 with central-european chars (8859-2). Adam, is it working for you as well? Thanks.
Status: RESOLVED → VERIFIED
> Adam, is it working for you as well? Yes, verified with Moz 1.1a and 1.1b on RedHat 7.1 - works OK.
You need to log in before you can comment on or make changes to this bug.