Closed
Bug 1368146
Opened 7 years ago
Closed 7 years ago
Update Screenshots to version 8.1.0
Categories
(Firefox :: Screenshots, defect)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
Attachments
(1 file)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8871883 -
Flags: feedback?(ianb)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8871883 [details] Bug 1368146 - Export Screenshots 8.1.0 to Firefox; https://reviewboard.mozilla.org/r/143402/#review147118
Attachment #8871883 -
Flags: review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8871883 [details] Bug 1368146 - Export Screenshots 8.1.0 to Firefox; https://reviewboard.mozilla.org/r/143402/#review147918 ::: browser/extensions/screenshots/moz.build:18 (Diff revision 1) > # AUTOMATIC INSERTION START > FINAL_TARGET_FILES.features['screenshots@mozilla.org']["webextension"] += [ > + 'webextension/.eslintrc.js', > 'webextension/assertIsTrusted.js', > 'webextension/blank.html', > 'webextension/buildSettings.js.template', This looks wrong. We want buildSettings.js, not the template file.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8871883 [details] Bug 1368146 - Export Screenshots 8.1.0 to Firefox; https://reviewboard.mozilla.org/r/143402/#review147782 Looks reasonable. I've put a few notes below. I'd like the .eslintrc.js shipping issue fixed before this ships. The other issues I think we can file bugs on, but we must work out the regressing code (i.e. yield -> await / picking up block changes landing in the tree) before the next version of screenshots ships. ::: browser/extensions/screenshots/bootstrap.js:48 (Diff revision 1) > } > }; > > +const appStartupObserver = { > + register() { > + Services.obs.addObserver(this, "sessionstore-windows-restored", false); // eslint-disable-line mozilla/no-useless-parameters I've a feeling this is going to mess with (mochi)tests when we try to enable screenshots for tests again, however, lets get this updated, and then work that out... ::: browser/extensions/screenshots/moz.build:15 (Diff revision 1) > ] > > # This file list is automatically generated by Screenshots' export scripts. > # AUTOMATIC INSERTION START > FINAL_TARGET_FILES.features['screenshots@mozilla.org']["webextension"] += [ > + 'webextension/.eslintrc.js', We shouldn't be trying to ship this file. ::: browser/extensions/screenshots/test/browser/browser_screenshots_ui_check.js:10 (Diff revision 1) > is(!!document.getElementById(id), expectPresent, "element " + id + (expectPresent ? " is" : " is not") + " present"); > } > } > > -add_task(async function() { > - await promiseScreenshotsEnabled(); > +add_task(function*() { > + yield promiseScreenshotsEnabled(); This is worrying, if we're regressing the latest changes from the tree - this needs to be re-imported into the github repo.
Attachment #8871883 -
Flags: review?(standard8) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8871883 [details] Bug 1368146 - Export Screenshots 8.1.0 to Firefox; https://reviewboard.mozilla.org/r/143402/#review147782 > We shouldn't be trying to ship this file. Fixed by 8.1.0 changes > This is worrying, if we're regressing the latest changes from the tree - this needs to be re-imported into the github repo. Cool. We'll fix this later in https://github.com/mozilla-services/screenshots/issues/2917
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0e0d7d31cd5 Export Screenshots 8.1.0 to Firefox; r=ianb,standard8
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e0e0d7d31cd5
Comment 9•7 years ago
|
||
== Change summary for alert #6946 (as of May 30 2017 19:29 UTC) == Improvements: 11% ts_paint_webext linux64 opt e10s 1,625.25 -> 1,438.58 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=6946
Updated•7 years ago
|
Assignee: nobody → jhirsch
Summary: Update Screenshots to version 8.0.0 → Update Screenshots to version 8.1.0
Updated•7 years ago
|
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•