Update Screenshots to version 10.10.0

RESOLVED FIXED in Firefox 55

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: _6a68, Assigned: _6a68)

Tracking

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55blocking fixed, firefox56 fixed, firefox57 fixed)

Details

Attachments

(1 attachment)

Attachment #8892677 - Flags: review?(dtownsend)
Comment on attachment 8892677 [details]
Bug 1386457 - Export Screenshots 10.10.0 to Firefox

https://reviewboard.mozilla.org/r/163670/#review169284
Attachment #8892677 - Flags: review?(dtownsend) → review+
Comment on attachment 8892677 [details]
Bug 1386457 - Export Screenshots 10.10.0 to Firefox

Approval Request Comment

[Feature/Bug causing the regression]:  
  https://github.com/mozilla-services/screenshots/issues/3257

[User impact if declined]:
  A hard-to-reproduce race condition between the web extension starting and Shield putting the user in a cohort.  Appears mostly with slow session restores (browser is upgrading, or user has lots of tabs, etc.). 

[Is this code covered by automated tests?]:
  No
  
[Has the fix been verified in Nightly?]:
  Screenshots & Release QA have verified the Try builds.

[Needs manual test from QE? If yes, steps to reproduce]: 
  No

[List of other uplifts needed for the feature/fix]:
  None

[Is the change risky?]:
  It's a low risk patch

[Why is the change risky/not risky?]:
  This prevents the web extension from trying to load twice and breaking itself

[String changes made/needed]:
  None
Attachment #8892677 - Flags: approval-mozilla-release?
Attachment #8892677 - Flags: approval-mozilla-beta?
Comment on attachment 8892677 [details]
Bug 1386457 - Export Screenshots 10.10.0 to Firefox

Per the email thread, I was able to confirm that this addon works much better with my buggy profile as well.
Attachment #8892677 - Flags: feedback+
Assignee: nobody → jhirsch
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e4c1a02148ec
Export Screenshots 10.10.0 to Firefox r=mossop
Keywords: checkin-needed
Comment on attachment 8892677 [details]
Bug 1386457 - Export Screenshots 10.10.0 to Firefox

one more screenshots bugfix for 55
Attachment #8892677 - Flags: approval-mozilla-release?
Attachment #8892677 - Flags: approval-mozilla-release+
Attachment #8892677 - Flags: approval-mozilla-beta?
Attachment #8892677 - Flags: approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-release/rev/c727b45826bf

Will land on Beta56 once all the post-merge bustage is cleaned up.
https://hg.mozilla.org/mozilla-central/rev/e4c1a02148ec
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1390985
No longer depends on: 1390985
Target Milestone: mozilla57 → Firefox 57
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.