Closed
Bug 1386457
Opened 7 years ago
Closed 7 years ago
Update Screenshots to version 10.10.0
Categories
(Firefox :: Screenshots, defect)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
mossop
:
review+
RyanVM
:
feedback+
jcristau
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release+
|
Details |
+++ This bug was initially created as a clone of Bug #1368146 +++ Changelog: https://github.com/mozilla-services/screenshots/blob/v10.4.0-export/CHANGELOG.md#version-10100
Comment hidden (mozreview-request) |
Updated•7 years ago
|
status-firefox55:
--- → affected
status-firefox56:
--- → affected
status-firefox57:
--- → affected
tracking-firefox55:
--- → blocking
Assignee | ||
Updated•7 years ago
|
Attachment #8892677 -
Flags: review?(dtownsend)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8892677 [details] Bug 1386457 - Export Screenshots 10.10.0 to Firefox https://reviewboard.mozilla.org/r/163670/#review169284
Attachment #8892677 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 3•7 years ago
|
||
Comment on attachment 8892677 [details] Bug 1386457 - Export Screenshots 10.10.0 to Firefox Approval Request Comment [Feature/Bug causing the regression]: https://github.com/mozilla-services/screenshots/issues/3257 [User impact if declined]: A hard-to-reproduce race condition between the web extension starting and Shield putting the user in a cohort. Appears mostly with slow session restores (browser is upgrading, or user has lots of tabs, etc.). [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Screenshots & Release QA have verified the Try builds. [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: It's a low risk patch [Why is the change risky/not risky?]: This prevents the web extension from trying to load twice and breaking itself [String changes made/needed]: None
Attachment #8892677 -
Flags: approval-mozilla-release?
Attachment #8892677 -
Flags: approval-mozilla-beta?
Comment 4•7 years ago
|
||
Comment on attachment 8892677 [details] Bug 1386457 - Export Screenshots 10.10.0 to Firefox Per the email thread, I was able to confirm that this addon works much better with my buggy profile as well.
Attachment #8892677 -
Flags: feedback+
Updated•7 years ago
|
Assignee: nobody → jhirsch
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e4c1a02148ec Export Screenshots 10.10.0 to Firefox r=mossop
Keywords: checkin-needed
Comment 6•7 years ago
|
||
Comment on attachment 8892677 [details] Bug 1386457 - Export Screenshots 10.10.0 to Firefox one more screenshots bugfix for 55
Attachment #8892677 -
Flags: approval-mozilla-release?
Attachment #8892677 -
Flags: approval-mozilla-release+
Attachment #8892677 -
Flags: approval-mozilla-beta?
Attachment #8892677 -
Flags: approval-mozilla-beta+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/c727b45826bf Will land on Beta56 once all the post-merge bustage is cleaned up.
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4c1a02148ec
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/4fb347610eaf
Updated•7 years ago
|
Target Milestone: mozilla57 → Firefox 57
Updated•7 years ago
|
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•