1368237 - Disable LeanPlumIntegration while in private browsing

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect, P1)

Description

[James Hugman [:jhugman] [@jhugman]]

Bug 1352568 landed the initial phases of LeanPlum integration. 

This bug is to toggle enabling and disabling of LeanPlum while the user is in private browsing, even if they have opted in for LeanPlum analytics.

PrivateBrowsing has a few entry and exit points, including but not exclusively:

 * private browsing mask in the tab tray controller
 * new private tab in today widget
 * spotlight
 * deeplinking (so other apps can open firefox in pbm).

The events for: 
 * savedLoginAndPassword, 
 * saveImage, 
 * openMailToLink, 
 * interactWithURLBar, 
 * savedBookmark,
 * openedBookmark

are all fired while in private browsing.

Comment 1

[Aaron Train [:aaronmt]]

* contextual menu on link long-press

Comment 2

[:sdaswani]

As a simplifying implementation, you can just shut off all Leanplum events when the user is in private mode. Jean has said she is basically in the dark with the events listed so no problem just shutting them all off.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

I think the simplest thing that could possibly work: 

Add a isPrivate flag to each track call. 

func track(_ isPrivate: Bool) {
    guard !isPrivate else { return }
    …
}

Alternatively, calling 

LeanPlumIntegration.sharedInstance.setEnabled(!isPrivate)


whenever viewWillAppear on a tab, and 

LeanPlumIntegration.sharedInstance.setEnabled(true)

on viewDidDisappear may also be a relatively straightforward approach.

Comment 4

[:sdaswani]

Yes, I was going to recommend the first implementation.

Comment 5

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Bryan, why does this patch need a persistent setting in the Preferences?

Comment 7

[Bryan Munar (:bkmunar)]

That was an experiment branch to test what was the best possible way to keep track of the private state; we're getting closer to a finished product

Comment 8

[:sdaswani]

merged in https://github.com/mozilla-mobile/firefox-ios/pull/2792