Closed Bug 1368245 Opened 7 years ago Closed 7 years ago

Intermittent browser/base/content/test/urlbar/browser_page_action_menu.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getTransferData]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" loc

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Iteration:
56.3 - Jul 24
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: aryx, Assigned: standard8)

Details

(Keywords: intermittent-failure, Whiteboard: [reserve-photon-structure][stockwell fixed:other])

Attachments

(1 file)

Bug 1368245 - Move browser_page_action_menu's copyURL test into its own clipboard subsuite specific test to try and avoid intermittents.
59 bytes, text/x-review-board-request
mak
: review+
Details 
https://treeherder.mozilla.org/logviewer.html#?job_id=102551089&repo=mozilla-central

09:20:39     INFO -  119 INFO TEST-START | browser/base/content/test/urlbar/browser_page_action_menu.js
09:20:40     INFO -  TEST-INFO | started process screenshot
09:20:40     INFO -  TEST-INFO | screenshot: exit 0
09:20:40     INFO -  Buffered messages logged at 09:20:39
09:20:40     INFO -  120 INFO Entering test bound bookmark
09:20:40     INFO -  121 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | "Bookmark This Page" == "Bookmark This Page" -
09:20:40     INFO -  122 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | true == true -
09:20:40     INFO -  123 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | "Edit This Bookmark" == "Edit This Bookmark" -
09:20:40     INFO -  124 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | true == true -
09:20:40     INFO -  125 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | "true" == "true" -
09:20:40     INFO -  Buffered messages logged at 09:20:40
09:20:40     INFO -  126 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | "Bookmark This Page" == "Bookmark This Page" -
09:20:40     INFO -  127 INFO TEST-PASS | browser/base/content/test/urlbar/browser_page_action_menu.js | true == true -
09:20:40     INFO -  128 INFO Leaving test bound bookmark
09:20:40     INFO -  129 INFO Entering test bound copyURL
09:20:40     INFO -  Buffered messages finished
09:20:40    ERROR -  130 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_page_action_menu.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getTransferData]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_page_action_menu.js :: copyURL :: line 89"  data: no]
09:20:40     INFO -  Stack trace:
09:20:40     INFO -      copyURL@chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_page_action_menu.js:89:3
09:20:40     INFO -      Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:753:21
09:20:40     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:748:9
09:20:40     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:668:7
Whiteboard: [photon-structure]
Whiteboard: [photon-structure] → [photon-structure] [triage]
Flags: qe-verify-
Priority: -- → P3
Whiteboard: [photon-structure] [triage] → [reserve-photon-structure]
I wonder if the copyurl test should be moved under the clipboard subsuite.
Assignee: nobody → standard8
I've just pushed a possible patch to try, we'll see how it comes out.
Attachment #8884772 - Flags: review?(mak77)
Try seemed happy with 10 re-runs of the tests on Win32, so lets see how it goes in the real world...
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8884772 [details]
Bug 1368245 - Move browser_page_action_menu's copyURL test into its own clipboard subsuite specific test to try and avoid intermittents.

https://reviewboard.mozilla.org/r/155652/#review161212

::: browser/base/content/test/urlbar/head.js:225
(Diff revision 1)
> +function promisePageActionPanelEvent(name) {
> +  return new Promise(resolve => {
> +    gPageActionPanel.addEventListener(name, () => {
> +      setTimeout(() => {
> +        resolve();
> +      });

Sounds like this should be an executeSoon?

::: browser/base/content/test/urlbar/head.js:236
(Diff revision 1)
> +  return new Promise(resolve => {
> +    gPageActionPanel.addEventListener("ViewShown", (event) => {
> +      let target = event.originalTarget;
> +      window.setTimeout(() => {
> +        resolve(target);
> +      }, 5000);

this is nonsense, 5 seconds?!
It should probably use waitForCondition, but I'm not sure which condition we are expecting to be satisfied here.
Surely not our fault, but would be better letting photon structure team know about this, we should not have this kind of timeouts in tests. Especially if the test expects to open a view multiple times and we wait 5s every time...
Attachment #8884772 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/367c57f680af
Move browser_page_action_menu's copyURL test into its own clipboard subsuite specific test to try and avoid intermittents. r=mak
Comment on attachment 8884772 [details]
Bug 1368245 - Move browser_page_action_menu's copyURL test into its own clipboard subsuite specific test to try and avoid intermittents.

https://reviewboard.mozilla.org/r/155652/#review161212

> Sounds like this should be an executeSoon?

Yep, fixed.

> this is nonsense, 5 seconds?!
> It should probably use waitForCondition, but I'm not sure which condition we are expecting to be satisfied here.
> Surely not our fault, but would be better letting photon structure team know about this, we should not have this kind of timeouts in tests. Especially if the test expects to open a view multiple times and we wait 5s every time...

I filed bug 1380021.
https://hg.mozilla.org/mozilla-central/rev/367c57f680af
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Iteration: --- → 56.3 - Jul 24
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure][stockwell fixed:other]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: